The AEC3 refined delay is inaccurate after a new delay estimator delay has been found |
|||||||
Issue descriptionIn AEC3, the delay estimator selects a coarse alignment and then a refined alignment is chosen on top of that based on the linear filter. After a new delay has been detected by the delay estimator, the linear filter is reset, and in some cases that causes the refined delay to be wrongly estimated for a short while before the linear filter has re-converged.
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3596e65961370cfb3618ee256d1b90dd636d09c1 commit 3596e65961370cfb3618ee256d1b90dd636d09c1 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 08 00:02:49 2018 Roll src/third_party/webrtc 81327d5..ed51a6e (12 commits) https://webrtc.googlesource.com/src.git/+log/81327d5..ed51a6e git log 81327d5..ed51a6e --date=short --no-merges --format='%ad %ae %s' 2018-06-07 gustaf@webrtc.org AEC3: Avoid static initializers 2018-06-07 peah@webrtc.org AEC3: Delay stabilization after a delay change 2018-06-07 peah@webrtc.org AEC3: Added filter preprocessing to avoid low frequency artefacts 2018-06-07 magjed@webrtc.org Android: Throw exception in CallSessionFileRotatingLogSink if dir is null 2018-06-07 gustaf@webrtc.org AEC3: Improved anti-aliasing filter for DSF 4 2018-06-07 mbonadei@webrtc.org Removing warning suppression flags from test/. 2018-06-07 mbonadei@webrtc.org Re-enabling SanitizerTest.MsanUninitialized. 2018-06-07 srte@webrtc.org Fixing issue where pacer budget increased in congestion. 2018-06-07 asapersson@webrtc.org Remove unused methods in VCMDecoderDataBase. 2018-06-07 nisse@webrtc.org Delete unused stats for preferred_bitrate. 2018-06-07 gustaf@webrtc.org AEC3: Move decimator filters to the new notation 2018-06-07 nisse@webrtc.org Delete RTP-specific values from the VideoCodecType enum. Created with: gclient setdep -r src/third_party/webrtc@ed51a6e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= chromium:846615 , chromium:850451 , chromium:848231 ,chromium:b/106732994,chromium:846615,chromium:none,chromium:846615,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5fa6c8ebdf457e84a74bc440a044f50ba4915e21 Reviewed-on: https://chromium-review.googlesource.com/1091287 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565471} [modify] https://crrev.com/3596e65961370cfb3618ee256d1b90dd636d09c1/DEPS
,
Jun 13 2018
We would like to merge this to M68. It has been tested in Canary and works well. The feature is only active beneath a Finch flag and can therefore be turned off if it would go wrong. Furthermore, a kill-switch was added that allows specifically turning off the added functionality. The CL we would like to merge is: -https://webrtc-review.googlesource.com/81682
,
Jun 13 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2018
After an offline analysis of a new recording, we decided to wait with the merge. I therefore remove the merge labels.
,
Jun 14 2018
,
Aug 23
,
Aug 27
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 7 2018