Issue metadata
Sign in to add a comment
|
Regression : Unnecessary "Your system last booted in Developer Mode..." screen is seen even device is in Normal mode |
||||||||||||||||||||||
Issue description
Chrome Version: 69.0.3451.0/10758.0.0 dev channel Kip, Daisy & Reks
OS: Chrome
Pre-condition : Device should be in Normal mode only(verified Mode)
What steps will reproduce the problem?
(1)Sign into User -> Sign out -> In sign-out screen press 'Ctrl+Shift+Alt+R' key to Power wash the Device('Reset this Chrome device' overlay is seen -> Now click on 'Restart' Button and devices gets restarted)
(2)Again 'Reset this Chrome device' overlay is seen with 'Cancel' and 'Powerwash' buttons -> click on 'Powerwash' option -> in 'Confirm Powerwash' dialog box select 'Continue' option
(3)Now 'Powerwash is in progress...' screen is seen -> after few seconds -> observe unnecessary
"Your system last booted in Developer Mode.Returning to Normal(Verified)Mode....Upon completion, the system will reboot" screen is seen
(Please refer Video)
Expected: Unnecessarily "Your system last booted in Developer Mode..." screen should not be seen as device is in Normal mode
Actual: Instead "Your system last booted in Developer Mode..." screen is seen even device is in Normal mode
This is Regression Issue as same is working fine in 69.0.3445.0/10738.0.0 dev-channel Reks
@jdufault : Please confirm the Issue
,
Jun 7 2018
Adding Beta blocker as this is a recent regression , please remove if not required
,
Jun 7 2018
,
Jun 7 2018
derat@ do you know who owns powerwash platform code? This seems unrelated to anything in chrome. I'm having a hard time tracking down a relevant owner who still works on CrOS.
,
Jun 7 2018
It's definitely not me. :-) I think that Mattias touched it recently.
,
Jun 8 2018
I have a hunch the culprit is https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1075274 ... and the bug owner wheel of fortune stops at: igorcov :-D
,
Jun 8 2018
Sorry, that CL is indeed the culprit. I've created a revert request in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1091316 Will need to think of better approach for the original bug to fix.
,
Jun 8 2018
The reason for that message is that powerwash does a "clobber-state fast safe keepimg", and the safe option keeps the install attributes file in place, while the tpm is reset. And there's a TODO: # TODO(tnagel): Drop install_attributes.pb after AUE of the last remaining # boards that don't support programmatic TPM reset (lumpy and stumpy). https://cs.corp.google.com/chromeos_public/src/platform2/init/clobber-state?type=cs&q=%22keepimg%22&sq=package:&g=0&l=71
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5b5d5489811aa33f1a74e477096b90eb1f451094 commit 5b5d5489811aa33f1a74e477096b90eb1f451094 Author: Igor <igorcov@chromium.org> Date: Mon Jun 11 20:44:37 2018 init: Drop install attributes, attestation and local tpm data from preserved files by clobber The AUE for lumpy and stumpy happened in version 65 (https://cros-goldeneye.corp.google.com/chromeos/console/eventLogBoard?name=lumpy) This change will delete the install attributes file at powerwash and will not trigger the wrong assumption from chromeos_startup that the device last booted in devmode. BUG= chromium:850447 TEST=Build image and check 850447. Change-Id: I82b92b7868d0baa4bf7d6ed9bf48e9330d89c5a9 Reviewed-on: https://chromium-review.googlesource.com/1093094 Commit-Ready: Igor <igorcov@chromium.org> Tested-by: Igor <igorcov@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Igor <igorcov@chromium.org> [modify] https://crrev.com/5b5d5489811aa33f1a74e477096b90eb1f451094/init/clobber-state
,
Jun 18 2018
This should be fixed now. Checked on eve device. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Jun 7 201816.3 MB
16.3 MB Download