New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850442 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Log time of day in GMT for Chrome launch

Project Member Reported by feuunk@google.com, Jun 7 2018

Issue description

We should log the time of day in GMT that Chrome is launched, so we can make a prediction about peakyness of traffic that will happen on Chrome launch.

Targetting to M68 since it's a small logging change, and will enable us to get QPS estimates much earlier.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a80e3739664310574bd1eccc3a012f18d722bab3

commit a80e3739664310574bd1eccc3a012f18d722bab3
Author: Florian Uunk <feuunk@chromium.org>
Date: Mon Jun 11 18:06:46 2018

Record the time of day in GMT at startup

This will be used to get traffic estimates for requests that are made
at Chrome startup.

Bug:  850442 
Change-Id: I72805e9a36184dc8d45e22d649f075ab19df0c04
Reviewed-on: https://chromium-review.googlesource.com/1090276
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566056}
[modify] https://crrev.com/a80e3739664310574bd1eccc3a012f18d722bab3/components/startup_metric_utils/browser/startup_metric_utils.cc
[modify] https://crrev.com/a80e3739664310574bd1eccc3a012f18d722bab3/tools/metrics/histograms/histograms.xml

Comment 2 by feuunk@google.com, Jun 11 2018

Labels: Merge-Request-68
Requesting merge for reasoning described in #1.
Let's wait until it lands in canary first and is verified. 
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 12 2018

Labels: -Merge-Request-68 Merge-Reject-68 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M68 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by feuunk@chromium.org, Jun 13 2018

Status: Verified (was: Assigned)
This is Canary now, and I've verified that the patch works as expected. Also, the UMA data looks good: https://uma.googleplex.com/histograms?endDate=20180611&dayCount=1&histograms=Startup.TimeOfDayGMT&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial

Comment 6 by feuunk@chromium.org, Jun 13 2018

Labels: -Type-Feature -Hotlist-Merge-Reject -Merge-Reject-68 Merge-Request-68 Type-Bug
Requesting an exception to the auto-reject in #4 for the following reasons:

- This patch is small, and all it does is add extra UMA logging
- The UMA data will be very valuable in providing us traffic estimates, which SRE will use to determine how much we need to scale our backends.

See here for more info (internal only): https://docs.google.com/document/d/1o8senySiqZwaWoFYIPw8_ReQZbAU7G0D3OCLRXTMmeQ/edit#heading=h.eww4j4q6yazg

Thanks!
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 13 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge to M68. Branch:3440
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 18 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a252579b3671af9ffeb6de50861928f9ef9d506e

commit a252579b3671af9ffeb6de50861928f9ef9d506e
Author: Florian Uunk <feuunk@chromium.org>
Date: Mon Jun 18 09:38:01 2018

Record the time of day in GMT at startup

This will be used to get traffic estimates for requests that are made
at Chrome startup.

Bug:  850442 
Change-Id: I72805e9a36184dc8d45e22d649f075ab19df0c04
Reviewed-on: https://chromium-review.googlesource.com/1090276
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566056}(cherry picked from commit a80e3739664310574bd1eccc3a012f18d722bab3)
Reviewed-on: https://chromium-review.googlesource.com/1104197
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#391}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/a252579b3671af9ffeb6de50861928f9ef9d506e/components/startup_metric_utils/browser/startup_metric_utils.cc
[modify] https://crrev.com/a252579b3671af9ffeb6de50861928f9ef9d506e/tools/metrics/histograms/histograms.xml

Sign in to add a comment