New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850410 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser crash is observed on sending feedback from Guest user.

Reported by aiman.an...@etouch.net, Jun 7 2018

Issue description

Chrome Version : 69.0.3452.0 (Official Build) Revision 0d0b79e107ffa727bd13f2636984c125ffc2040c-refs/branch-heads/3452@{#1} (32/64 Bit)

OS : Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and open Guest Browser.
2. In guest user navigate to chrome://settings/help.
3. Enter some text in 'Report and Issue' overlay and click on Send.
4. Observe.

Uploaded Crash Report ID d857f998c4e3fd19 (Local Crash ID: 7acdee8e-f87b-466f-8b2e-45847759e5dc)

Actual Result : Browser crash is observed on sending feedback from Guest user.

Expected Result : Browser should not crash.

This is a regression issue, broken in M-69 and will soon update other info.
Good Build : 69.0.3451.0 (Revision : 564769)
Bad Build : 69.0.3452.0 (Revision : 565143)

 
Actual Result.mp4
471 KB View Download
Expected Result.mp4
360 KB View Download
Labels: hasbisect-per-revision RegressedIn-69 ET-MUM-Reported OS-Mac
Owner: jochen@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 564869 (known good),but no later than 564870 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/7052b23c75fa7cebab3ba13bcc6f83f39c53f40a..324138ca59bab8c60c2a641f8530073934785423

Suspect: https://chromium.googlesource.com/chromium/src/+/324138ca59bab8c60c2a641f8530073934785423

jochen: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You


Cc: blundell@chromium.org
looking
Cc: gov...@chromium.org abdulsyed@chromium.org ligim...@chromium.org
Labels: ReleaseBlock-Dev
Please find the Stack Trace for the crash id:
---------------------------------------------
Thread 0 (id: 0x1c68) CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000050 ] MAGIC SIGNATURE THREAD
Stack Quality84%Show frame trust levels
0x00007ffbd6259164	(chrome.dll + 0x00a69164 )	ToolbarActionView::IsMenuRunning()
0x00007ffbd7dc9d67	(chrome.dll -feedback_uploader_chrome.cc:57 )	feedback::FeedbackUploaderChrome::StartDispatchingReport()
0x00007ffbd710e473	(chrome.dll -feedback_uploader.cc:192 )	feedback::FeedbackUploader::UpdateUploadTimer()
0x00007ffbd710e004	(chrome.dll -feedback_uploader.cc:208 )	feedback::FeedbackUploader::QueueReportWithDelay(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::TimeDelta)
0x00007ffbd710df49	(chrome.dll -feedback_uploader.cc:76 )	feedback::FeedbackUploader::QueueReport(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &)
0x00007ffbd6cd97a4	(chrome.dll -feedback_data.cc:148 )	feedback::FeedbackData::SendReport()
0x00007ffbd6db5930	(chrome.dll -post_task_and_reply_impl.cc:97 )	base::`anonymous namespace'::PostTaskAndReplyRelay::RunReply
0x00007ffbd6db59ef	(chrome.dll -bind_internal.h:649 )	base::internal::Invoker<base::internal::BindState<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay),base::(anonymous namespace)::PostTaskAndReplyRelay>,void ()>::RunOnce
0x00007ffbd580ff14	(chrome.dll -task_annotator.cc:101 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x00007ffbd580f9eb	(chrome.dll -message_loop.cc:319 )	base::MessageLoop::RunTask(base::PendingTask *)
0x00007ffbd580f437	(chrome.dll -message_loop.cc:373 )	base::MessageLoop::DoWork()
0x00007ffbd58ff868	(chrome.dll -message_pump_win.cc:173 )	base::MessagePumpForUI::DoRunLoop()
0x00007ffbd5854ac7	(chrome.dll -message_pump_win.cc:56 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x00007ffbd580ef90	(chrome.dll -run_loop.cc:102 )	base::RunLoop::Run()
0x00007ffbd5b91873	(chrome.dll -chrome_browser_main.cc:2194 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x00007ffbd5b91677	(chrome.dll -browser_main_loop.cc:983 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x00007ffbd5b91622	(chrome.dll -browser_main_runner_impl.cc:169 )	content::BrowserMainRunnerImpl::Run()
0x00007ffbd63756ce	(chrome.dll -browser_main.cc:51 )	content::BrowserMain(content::MainFunctionParams const &,std::unique_ptr<content::BrowserProcessSubThread,std::default_delete<content::BrowserProcessSubThread> >)
0x00007ffbd68c77fa	(chrome.dll -content_main_runner_impl.cc:620 )	content::RunBrowserProcessMain(content::MainFunctionParams const &,content::ContentMainDelegate *,std::unique_ptr<content::BrowserProcessSubThread,std::default_delete<content::BrowserProcessSubThread> >)
0x00007ffbd5805765	(chrome.dll -content_main_runner_impl.cc:964 )	content::ContentMainRunnerImpl::Run()
0x00007ffbd57f5172	(chrome.dll -main.cc:459 )	service_manager::Main(service_manager::MainParams const &)
0x00007ffbd57f4a07	(chrome.dll -content_main.cc:19 )	content::ContentMain(content::ContentMainParams const &)
0x00007ffbd57f1af1	(chrome.dll -chrome_main.cc:101 )	ChromeMain
0x00007ff69b6635d5	(chrome.exe -main_dll_loader_win.cc:201 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x00007ff69b661698	(chrome.exe -chrome_exe_main_win.cc:230 )	wWinMain
0x00007ff69b7207d5	(chrome.exe -exe_common.inl:283 )	__scrt_common_main_seh
0x00007ffc19cc1fe3	(KERNEL32.dll + 0x00011fe3 )	BaseThreadInitThunk
0x00007ffc1adbf060	(ntdll.dll + 0x0006f060 )	RtlUserThreadStart

Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Status: Started (was: Assigned)
Jochen: This goes without saying I'm sure, but feel free to proactively revert the CL if the underlying condition is either not obvious or not obviously fixable, and then I (or you if interested :) can fix the underlying condition before relanding.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95edae15f9e758f2942f49948ffc9288c9a76f19

commit 95edae15f9e758f2942f49948ffc9288c9a76f19
Author: Jochen Eisinger <jochen@chromium.org>
Date: Thu Jun 07 11:27:25 2018

Handle OTR profiles in the IdentityManagerFactory

BUG= 850410 
R=blundell@chromium.org

Change-Id: Id2fde700fdc72d6fe2d2f623293eb368ddd52605
Reviewed-on: https://chromium-review.googlesource.com/1090277
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565231}
[modify] https://crrev.com/95edae15f9e758f2942f49948ffc9288c9a76f19/chrome/browser/signin/identity_manager_factory.cc

Status: Fixed (was: Started)
Thanks for the quick fix, Jochen!
Labels: TE-Verified-M69 TE-Verified-69.0.3453.0
Update : 

Retested above issue on Windows(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.6) OS using latest Canary #69.0.3453.0 and issue is fixed. Browser crash is not seen on sending feedback from guest user. 

Kindly review the attached screen-cast.

Thank You!

Canary Behaviour.mp4
440 KB View Download

Sign in to add a comment