New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850386 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

viz: Define a type for |frame_token|

Project Member Reported by sadrul@chromium.org, Jun 7 2018

Issue description

CompositorFrameMetadata::frame_token is a uint32_t, which is incremented for every frame, and can wrap around back to 1. So directly comparing these frame-tokens wouldn't always work. There is a FrameTokenGT() helper function that can be used. But it might be better to define a custom type for it, so that accidental comparison cannot happen.
 

Comment 1 by samans@chromium.org, Jun 19 2018

Cc: fsam...@chromium.org samans@chromium.org

Sign in to add a comment