New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850385 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-03
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Wrong translation in Gallery app: [ja]"削減量"

Project Member Reported by yamaguchi@chromium.org, Jun 7 2018

Issue description

Chrome Version: confirmed on 66.0.3359.0 and 69.0.3453.0

Steps To Reproduce:
(1) Set system UI language to Japanese.
(2) Open an image in Gallery app.
(3) Click "Edit" button
(4) Make any change (e.g. Rotate clockwise, and then counterclockwise)
(5) Observe the status bar of the app, which is next to "overwrite original" label.

Expected Result:
Some translation  that means "(the file has been) Saved".
- "保存済み"
- "保存しました"

(In English, the message here is "Saved".)


Actual Result:
"削減量" meaning "amount which is/was saved"

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
always

What is the impact to the user, and is there a workaround? If so, what is
it?
This is UI message issue.

This indicates that there's probably an unintentional merger between text resource entries.
 
Seems IDS_FILE_BROWSER_GALLERY_SAVED has been merged with IDS_DATA_REDUCTION_BREAKDOWN_SAVED_TITLE in another file due to the exactly the same en-us string "Saved".
We'd need to add meaning= attribute to the one for Gallery, because  Translation ID: 6333335057236774263 ls already filled with the description for data saver.

https://cs.chromium.org/chromium/src/chrome/app/chromeos_strings.grdp?type=cs&q=%22++Saved%22+file:grd.?&sq=package:chromium&g=0&l=528
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chrome_strings.grd?q=%22Title+for+the+data+saved+column%22&sq=package:chromium&g=0&l=1159

Owner: yamaguchi@chromium.org
Status: Started (was: Available)
Note: the overwrite from the Gallery one to Data Saver's one happened on 2017/06/26. However there are some languages which were not updated then. Such languages would have inverse issue (i.e. data saver saying "saved to disk" whereas it should say "reduced amount").
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8181842caba18dc7c0aacfb792529f3b35de6371

commit 8181842caba18dc7c0aacfb792529f3b35de6371
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Jun 08 03:34:30 2018

Split wrongly merged text resource for "saved to disk" indicator.

"Saved" also appears as IDS_DATA_REDUCTION_BREAKDOWN_SAVED_TITLE
in src/chrome/android/java/strings/android_chrome_strings.grd.
It has caused that Gallery app say "amount reduced" in Japanese
whereas it should say "storing done". After this change we can put
separate translations for those two phrases.

Bug:  850385 
Change-Id: Ie8204c023df771fcf22dac2fb9e177408097e880
Reviewed-on: https://chromium-review.googlesource.com/1090518
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565527}
[modify] https://crrev.com/8181842caba18dc7c0aacfb792529f3b35de6371/chrome/app/chromeos_strings.grdp

NextAction: 2018-06-19
This needs to be verified after new translation is done.
I'll make sure that the entries are sent to translation request, on 6/19 (a month ahead of Chrome 69 branch).
Cc: sashab@chromium.org satorux@chromium.org
NextAction: 2018-07-03
Status: Fixed (was: Started)
The entry has been created in the translation console. 5131906772349523463
To be verified after the translation is done.

Tentatively setting the NextAction date 2 weeks from now, but I don't know when the translation will be done.
The NextAction date has arrived: 2018-07-03

Sign in to add a comment