ChromeOS Gallery App: support video files as well as image files |
||||
Issue descriptionChrome Version : 69 Hacky prototype is here: https://chromium-review.googlesource.com/c/chromium/src/+/1082186 From the blocked bug, approach for MVP is, - Clicking on the thumbnail in Camera should direct to Gallery app [in Thumbnail View mode] - Add the ability to view video thumbnails to Gallery app [in Thumbnail View only] - Gallery app will show all image and video files, not just those taken by the Camera app - Double-clicking on a video file via Files app launches the existing Video app (no change in behavior)
,
Jun 20 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424 commit 5659d54d72e6bf5bf5bb6b5c697ec673e6f05424 Author: Trent Apted <tapted@chromium.org> Date: Thu Jun 21 07:59:58 2018 CrOS Gallery: Add basic <video> support. Adds video formats to the list of files that the CrOS Gallery app loads and adds support for loading them into <video> element using stock controls. Disable editing (crop, rotate, etc.). Pressing 'e' will have no effect if a video is showing. Disable most transitions and transforms used for layout of images. They look silly on video controls. Remaining follow-ups: - add margins when the bottom ribbon overlaps the scrubber, - add play icon overlays in the thumbnail view, - grey-out/hide the edit and print buttons - autoplay video in slideshow (maybe). Bug: 850372 Test: GalleryJsTest.ImageViewTest Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idb582960ccd4141102ff44a70d34a320185853e1 Reviewed-on: https://chromium-review.googlesource.com/1082186 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569185} [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/css/gallery.css [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/gallery_item.js [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/gallery_item_unittest.js [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/gallery_util.js [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/gallery_util_unittest.js [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/image_editor/image_editor.js [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/image_editor/image_loader.js [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/image_editor/image_view.js [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/image_editor/image_view_unittest.html [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/image_editor/image_view_unittest.js [modify] https://crrev.com/5659d54d72e6bf5bf5bb6b5c697ec673e6f05424/ui/file_manager/gallery/js/slide_mode.js
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4b08b30d73b29296b90f627ebf4be0fa7f1698e commit c4b08b30d73b29296b90f627ebf4be0fa7f1698e Author: Trent Apted <tapted@chromium.org> Date: Fri Jun 22 07:39:59 2018 CrOS Gallery: Avoid the ribbon overlapping the <video> scrubber. Currently video taller than the aspect of the gallery window can have its scrubber controls overlapped by the thumbnail ribbon at the bottom. This just adds a CSS rule to moves the video element away from the top and bottom edges when the ribbon is visible. If the video is "wide" enough, there's no effect. Bug: 850372 Change-Id: I26db28fab80ef5be136692b25c14b704a4a3f7b2 Reviewed-on: https://chromium-review.googlesource.com/1109442 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#569551} [modify] https://crrev.com/c4b08b30d73b29296b90f627ebf4be0fa7f1698e/ui/file_manager/gallery/css/gallery.css
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/811956127bad35f07405cc9c485aef4b82b1c6f5 commit 811956127bad35f07405cc9c485aef4b82b1c6f5 Author: Trent Apted <tapted@chromium.org> Date: Wed Jun 27 07:00:05 2018 CrOS Gallery: Add a "play" overlay on video in thumbnail view. Double-clicking a video in thumbnail mode will also "activate" it when it's loaded in the slide mode. That is, it will autoplay. Renames Gallery::onChangeToSlideMode_() to Gallery::onThumbnailActivated_() since it's not used for anything else. That passes a boolean |activate| arg to Gallery::changeCurrentMode_() which invokes {mode}activateConetent() once the load associated with the mode change is complete. Test: GalleryBrowserTest.ActivateVideoFromThumbnailMode Bug: 850372 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie93448d8c643e842e1f871514a3283706b587900 Reviewed-on: https://chromium-review.googlesource.com/1109595 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570677} [modify] https://crrev.com/811956127bad35f07405cc9c485aef4b82b1c6f5/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/811956127bad35f07405cc9c485aef4b82b1c6f5/ui/file_manager/gallery/css/gallery.css [add] https://crrev.com/811956127bad35f07405cc9c485aef4b82b1c6f5/ui/file_manager/gallery/images/play_arrow.svg [add] https://crrev.com/811956127bad35f07405cc9c485aef4b82b1c6f5/ui/file_manager/gallery/images/play_arrow_hover.svg [modify] https://crrev.com/811956127bad35f07405cc9c485aef4b82b1c6f5/ui/file_manager/gallery/js/gallery.js [modify] https://crrev.com/811956127bad35f07405cc9c485aef4b82b1c6f5/ui/file_manager/gallery/js/slide_mode.js [modify] https://crrev.com/811956127bad35f07405cc9c485aef4b82b1c6f5/ui/file_manager/gallery/js/thumbnail_mode.js [modify] https://crrev.com/811956127bad35f07405cc9c485aef4b82b1c6f5/ui/file_manager/integration_tests/gallery/slide_mode.js
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18b2ef603c8bfa5548c0f8cb03c282e69eddaded commit 18b2ef603c8bfa5548c0f8cb03c282e69eddaded Author: Trent Apted <tapted@chromium.org> Date: Wed Jun 27 09:02:13 2018 CrOS Gallery: Disable (hide) Edit and Print for <video>. Bug: 850372 Test: GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5ce2e7e3adf1a3619d0cec18c9133f231c2749c0 Reviewed-on: https://chromium-review.googlesource.com/1114525 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#570702} [modify] https://crrev.com/18b2ef603c8bfa5548c0f8cb03c282e69eddaded/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/18b2ef603c8bfa5548c0f8cb03c282e69eddaded/ui/file_manager/gallery/js/slide_mode.js [modify] https://crrev.com/18b2ef603c8bfa5548c0f8cb03c282e69eddaded/ui/file_manager/integration_tests/gallery/slide_mode.js
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fc051bdb41c4f6891e22bc08d25b9b0de9a2a87 commit 7fc051bdb41c4f6891e22bc08d25b9b0de9a2a87 Author: Noel Gordon <noel@chromium.org> Date: Wed Jun 27 13:01:46 2018 Disable GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons Flakes in RELEASE on linux-chromeos-rel CQ bot. Tbr: tapted Bug: 850372 , 857021 Change-Id: I548307fa8a93689a348f2e96504815e3fe27cf44 Reviewed-on: https://chromium-review.googlesource.com/1116879 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570745} [modify] https://crrev.com/7fc051bdb41c4f6891e22bc08d25b9b0de9a2a87/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
,
Jun 27 2018
,
Jul 17
Gallery UI work is done. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, Jun 7 2018