New issue
Advanced search Search tips

Issue 850370 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Jun 2018
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

font-variant-east-asian serializes out of order

Project Member Reported by ericwilligers@chromium.org, Jun 7 2018 
Spec:
https://drafts.csswg.org/css-fonts/#propdef-font-variant-east-asian
normal | [ <east-asian-variant-values> || <east-asian-width-values> || ruby ]

Blink serializes keywords in the order they appear, not the order from the above grammar. Firefox and WebKit serialize font-variant-east-asian correctly.

Test case: https://jsfiddle.net/ericwilligers/k870wgmz/
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aca4e551db75160ad14b9223299366f5200f1ae

commit 5aca4e551db75160ad14b9223299366f5200f1ae
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Fri Jun 08 00:19:02 2018

CSS: font-variant-east-asian serializes in canonical order

We serialize the east-asian-variant-value, then east-asian-width-value,
then 'ruby'.

Spec: https://drafts.csswg.org/css-fonts/#propdef-font-variant-east-asian

BUG= 850370 

Change-Id: I7c5d68f772cc91aa96cd04aa2f0b89b47be62329
Reviewed-on: https://chromium-review.googlesource.com/1090528
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565480}
[add] https://crrev.com/5aca4e551db75160ad14b9223299366f5200f1ae/third_party/WebKit/LayoutTests/css-parser/font-variant-east-asian-parsing.html
[modify] https://crrev.com/5aca4e551db75160ad14b9223299366f5200f1ae/third_party/blink/renderer/core/css/parser/font_variant_east_asian_parser.h

Comment 2 by ericwilligers@chromium.org, Jun 8 2018

Owner: ericwilligers@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment