Make content_browsertests pass with ServiceWorkerServicification using mojo.fyi.network_content_browsertests.filter |
||
Issue descriptionThese two more tests are failing than NetworkService after crrev.com/c/1088463 lands. ServiceWorkerBlackBoxBrowserTest.Registration (../../content/browser/service_worker/service_worker_browsertest.cc:2619) ServiceWorkerBrowserTest.ResponseFromHTTPSServiceWorkerIsMarkedAsSecure (../../content/browser/service_worker/service_worker_browsertest.cc:2454) We may need to initialize ResourceMessageFilter appropriately. == Crash dump == BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x7f0531a6903c base::debug::StackTrace::StackTrace() #1 0x000000d02c35 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f052720a030 <unknown> #3 0x7f052f99d68a content::ResourceMessageFilter::Clone() #4 0x7f052f6b8228 _ZN4base8internal13FunctorTraitsIMN7content21BackgroundSyncContextEFvN4mojo16InterfaceRequestIN5blink5mojom21BackgroundSyncServiceEEEEvE6InvokeISB_13scoped_refptrIS3_EJS9_EEEvT_OT0_DpOT1_ #5 0x7f0531992f40 base::debug::TaskAnnotator::RunTask() #6 0x7f05319bec96 base::internal::IncomingTaskQueue::RunTask() #7 0x7f05319c28c7 base::MessageLoop::RunTask() #8 0x7f05319c2cda base::MessageLoop::DeferOrRunPendingTask() #9 0x7f05319c2f6e base::MessageLoop::DoWork() #10 0x7f0531a8bc29 base::MessagePumpLibevent::Run() #11 0x7f05319c21f1 base::MessageLoop::Run() #12 0x7f05319f5e16 base::RunLoop::Run() #13 0x7f0531a3373a base::Thread::Run() #14 0x7f052f6ff4b4 content::BrowserProcessSubThread::IOThreadRun() #15 0x7f052f6ff3ff content::BrowserProcessSubThread::Run() #16 0x7f0531a33cbf base::Thread::ThreadMain() #17 0x7f0531a7e22f base::(anonymous namespace)::ThreadFunc() #18 0x7f0527881494 start_thread #19 0x7f05272bfa8f clone
,
Jun 7 2018
crrev.com/c/1090423 revealed another failure of ServiceWorkerBrowserTest.ResponseFromHTTPSServiceWorkerIsMarkedAsSecure. This is the stack trace of it: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x7ff3bc0d803c base::debug::StackTrace::StackTrace() #1 0x000000d02c35 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7ff3b1879030 <unknown> #3 0x7ff3bba99537 net::X509Certificate::EqualsExcludingChain() #4 0x00000091fc5c content::ServiceWorkerBrowserTest_ResponseFromHTTPSServiceWorkerIsMarkedAsSecure_Test::RunTestOnMainThread() #5 0x000000d0294e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x000000d9a346 content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x7ff3b9d62f21 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x7ff3ba258355 content::StartupTaskRunner::RunAllTasksNow() #9 0x7ff3b9d6162c content::BrowserMainLoop::CreateStartupTasks() #10 0x7ff3b9d65d45 content::BrowserMainRunnerImpl::Initialize() #11 0x7ff3b9d65ca7 content::BrowserMainRunnerImpl::Initialize() #12 0x000000d99b2d ShellBrowserMain() #13 0x000000d4f57d content::ShellMainDelegate::RunProcess() #14 0x7ff3ba8256c3 content::RunBrowserProcessMain() #15 0x7ff3ba8267c4 content::ContentMainRunnerImpl::Run() #16 0x7ff3b78926bf service_manager::Main() #17 0x7ff3ba8245b4 content::ContentMain() #18 0x000000d024b2 content::BrowserTestBase::SetUp() #19 0x000000cf7644 content::ContentBrowserTest::SetUp() #20 0x000000bf0e1d testing::Test::Run() #21 0x000000bf1a80 testing::TestInfo::Run() #22 0x000000bf1f97 testing::TestCase::Run() #23 0x000000bfd987 testing::internal::UnitTestImpl::RunAllTests() #24 0x000000bfd4fd testing::UnitTest::Run() #25 0x000000d3d751 base::TestSuite::Run() #26 0x000000cfb3d7 content::ContentTestLauncherDelegate::RunTestSuite() #27 0x000000d22ff0 content::LaunchTests() #28 0x000000cfb390 main #29 0x7ff3b18662b1 __libc_start_main #30 0x0000004bf02a _start
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fe561deba3d527d470b48f9ee4585c133ce97a8 commit 4fe561deba3d527d470b48f9ee4585c133ce97a8 Author: Makoto Shimazu <shimazu@chromium.org> Date: Thu Jun 07 10:26:47 2018 Make ResourceMessageFilter::Clone callable before channel is connected Currently, service worker can create a new RenderProcessHostImpl and immediately call RenderProcessHost::CreateURLLoaderFactory, but it assumes that the channel has already been established. This CL is to make it callable even before the channel preparation. Bug: 850355 Change-Id: I94789478677c767e06460b4318918279bf11a926 Reviewed-on: https://chromium-review.googlesource.com/1090423 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565219} [modify] https://crrev.com/4fe561deba3d527d470b48f9ee4585c133ce97a8/content/browser/loader/resource_message_filter.cc [modify] https://crrev.com/4fe561deba3d527d470b48f9ee4585c133ce97a8/content/browser/loader/resource_message_filter.h
,
Jun 12 2018
Created issue 851831 for ServiceWorkerBrowserTest.ResponseFromHTTPSServiceWorkerIsMarkedAsSecure.
,
Jul 3
Issue 851304 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by falken@chromium.org
, Jun 7 2018