When deciding if a commit has interesting files, we only check for files in the recipes directory, or to the infra/config/recipes.cfg file. We should also consider files tagged with the recipes git attribute. https://chromium.googlesource.com/infra/luci/recipes-py/+/master/recipe_engine/fetch.py#35
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3ef114ae5849398b2aeb847d97a4ed1028597297 commit 3ef114ae5849398b2aeb847d97a4ed1028597297 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Jun 07 18:37:34 2018 Remove --use-gitiles options from remote_run. It doesn't appear to be used. Bug: 850351 Change-Id: Ia008d94b34029d437b4f633a7ec02b4d8b603e6a Reviewed-on: https://chromium-review.googlesource.com/1090216 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/3ef114ae5849398b2aeb847d97a4ed1028597297/scripts/master/master_gen.py [modify] https://crrev.com/3ef114ae5849398b2aeb847d97a4ed1028597297/masters/master.chromium/master_full_cfg.py [modify] https://crrev.com/3ef114ae5849398b2aeb847d97a4ed1028597297/scripts/slave/unittests/remote_run_test_disabled.py [modify] https://crrev.com/3ef114ae5849398b2aeb847d97a4ed1028597297/scripts/master/factory/remote_run_factory.py [modify] https://crrev.com/3ef114ae5849398b2aeb847d97a4ed1028597297/scripts/slave/remote_run.py
Issue 848791 has been merged into this issue.
Assigning to Edward, since he's working on this (I think).
Yup
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/recipes-py/+/11db7d01eaa21d7706966a532ee36bddc9000e9a commit 11db7d01eaa21d7706966a532ee36bddc9000e9a Author: Edward Lemur <ehmaldonado@chromium.org> Date: Mon Jun 11 18:31:26 2018 recipe_engine: Remove Gitiles backend from fetch. Bug: 850351 Change-Id: I9428a39255d517c8d55a867e9ea34ec6f99ab5ea Reviewed-on: https://chromium-review.googlesource.com/1079316 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/11db7d01eaa21d7706966a532ee36bddc9000e9a/recipe_engine/unittests/fetch_test.py [modify] https://crrev.com/11db7d01eaa21d7706966a532ee36bddc9000e9a/recipe_engine/fetch.py [modify] https://crrev.com/11db7d01eaa21d7706966a532ee36bddc9000e9a/recipe_engine/remote.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/recipes-py/+/a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb commit a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb Author: Edward Lemur <ehmaldonado@chromium.org> Date: Wed Jun 20 15:51:53 2018 autoroller: Take into account files with the recipes git attribute. Bug: 850351 Change-Id: I962ff4080aeffac61a1bf1b8e8114f6293106c98 Reviewed-on: https://chromium-review.googlesource.com/1077758 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb/recipe_engine/unittests/fetch_test.py [add] https://crrev.com/a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb/recipe_engine/unittests/gitattr_checker_test.py [modify] https://crrev.com/a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb/recipe_engine/fetch.py [add] https://crrev.com/a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb/recipe_engine/gitattr_checker.py
Looks like this works :) crrev.com/081487b9fb0603e9e369ce7ef42c0300a5ca55ae was rolled into build/ at crrev.com/668495430194dff36ab1709286b7f76596b42395 because of the .gitattributes file.
Thanks!!
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/recipes-py/+/94bb0a758456a5df6891677a8cf2876c07ea5f0c commit 94bb0a758456a5df6891677a8cf2876c07ea5f0c Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Jun 21 21:45:25 2018 Fix typo in autoroll code. Introduced in a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb. Needs more tests :) TBR=ehmaldonado@chromium.org Bug: 850351 Change-Id: Ib63a705c2210b7b2d605cf0f8eafbb7d80509f81 Reviewed-on: https://chromium-review.googlesource.com/1110937 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/94bb0a758456a5df6891677a8cf2876c07ea5f0c/recipe_engine/gitattr_checker.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/recipes-py/+/09ac15a0e9da9cf8f2c22320968f21544a0b25f0 commit 09ac15a0e9da9cf8f2c22320968f21544a0b25f0 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Fri Jun 22 20:02:46 2018 gitattr_checker: Add tests for the cache. Add tests to check that the cache for gitattributes files works as intended. Bug: 850351 Change-Id: I99b16db67c86b0d2fd9b34d1a7935dae8381675f Reviewed-on: https://chromium-review.googlesource.com/1111561 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/09ac15a0e9da9cf8f2c22320968f21544a0b25f0/recipe_engine/unittests/gitattr_checker_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/recipes-py/+/359385a94a0912af40d41eccc3fc594e68ddb65e commit 359385a94a0912af40d41eccc3fc594e68ddb65e Author: Edward Lemur <ehmaldonado@chromium.org> Date: Mon Jun 25 23:56:39 2018 autoroller: Search for gitattributes files only in modified dirs. Search for .gitattributes files in the dirs with modified files in a given revision, instead of the entire tree, which might be more efficient for larger repositories. Bug: 850351 Change-Id: Ib28c61a59427c55661c40695948e30bee5cee193 Reviewed-on: https://chromium-review.googlesource.com/1114137 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/359385a94a0912af40d41eccc3fc594e68ddb65e/recipe_engine/unittests/fetch_test.py [modify] https://crrev.com/359385a94a0912af40d41eccc3fc594e68ddb65e/recipe_engine/unittests/gitattr_checker_test.py [modify] https://crrev.com/359385a94a0912af40d41eccc3fc594e68ddb65e/recipe_engine/fetch.py [modify] https://crrev.com/359385a94a0912af40d41eccc3fc594e68ddb65e/recipe_engine/gitattr_checker.py
Comment 1 by bugdroid1@chromium.org
, Jun 7 2018