New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850348 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove flag "disable-new-files-app-navigation" once it's fully rolled out

Project Member Reported by lucmult@chromium.org, Jun 7 2018

Issue description

This flag is intended to be used during M-69 launch and after that the functionality should be always enabled.

This bug is to track the remove of the flag.
 
Labels: -Pri-3 Pri-2
Tracking bug for feature behind the flag: https://bugs.chromium.org/p/chromium/issues/detail?id=841640
Cc: weifangsun@chromium.org
Labels: -TargetedFor-70 -M-70 M-72 TargetedFor-72
From our discussions today, sounds like this should be more like M72 :)
Labels: CrOSFilesFeature-NavRefresh
Summary: Remove flag "disable-new-files-app-navigation" once it's fully rolled out (was: Remove flag "new-files-app-navigation" once it's fully rolled out)
Flag is being renamed to disable-new-files-app-navigation
Status: Started (was: Assigned)
Doing this cleanup before starting changes to support the new My files allowing folders/files.
Issue 880132 has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40364c8ffc40b35c55deef3c0be44b65a69e217f

commit 40364c8ffc40b35c55deef3c0be44b65a69e217f
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Oct 25 01:00:07 2018

Remove flag disable-new-files-app-navigation 1 of 2 CLs

Remove from NavigationListModel and fix its tests.

Remove drive expanded default from DirectoryTree.

Remove test helper and fix tests.

There is no change in behaviour for users, NavigationListModel changes
in tests are due to new directory tree behaviour introduced with "My
files", where shortcuts are sorted by their label, instead of by
order they were added.

Bug:  850348 
Change-Id: I0220d46459e54331493775b1275007ece3db2311
Reviewed-on: https://chromium-review.googlesource.com/c/1297854
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602550}
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/integration_tests/file_manager/create_new_folder.js
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/integration_tests/file_manager/drive_specific.js
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/integration_tests/file_manager/metadata.js
[modify] https://crrev.com/40364c8ffc40b35c55deef3c0be44b65a69e217f/ui/file_manager/integration_tests/remote_call.js

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0aeb8263754c1bec641c5c291bc9000bf53ebfc

commit e0aeb8263754c1bec641c5c291bc9000bf53ebfc
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Oct 30 10:16:44 2018

Remove dead code

Remove method flatNavigationItems_ that should have been removed in
crrev.com/c/1297854 because since then this method isn't used anymore.

Bug:  850348 
Change-Id: I598d9fa5b89c2897c9e1f6126663b8da2f932619
Reviewed-on: https://chromium-review.googlesource.com/c/1306952
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603849}
[modify] https://crrev.com/e0aeb8263754c1bec641c5c291bc9000bf53ebfc/ui/file_manager/file_manager/foreground/js/navigation_list_model.js

Sign in to add a comment