New issue
Advanced search Search tips

Issue 850346 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove TabManager.TabRanker.Result histogram

Project Member Reported by michae...@chromium.org, Jun 7 2018

Issue description

TabManager.TabRanker.Result is always "Success" and should be replaced with a DCHECK.

The TabScorePredictor has to load the model preprocessor config (once) and then pre-process each input before running it through the inference function. Theoretically this could fail if the config failed to load or if the input wasn't formatted properly, so the TabScorePredictor currently emits an UMA histogram with the success or error result of these operations.

Out of >100 million entries so far, all of them have been "Success". This confirms that these operations shouldn't fail; a failure would be the result of a coding error. We should remove the TabManager.TabRanker.Result histogram and instead enforce success with a DCHECK.
 
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!
Components: Internals>ResourceCoordinator
Status: Verified (was: Assigned)

Sign in to add a comment