New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850343 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Investigate disabled test suites on Win10 x64 Tests (dbg)

Project Member Reported by martiniss@chromium.org, Jun 7 2018

Issue description

As part of bringing up the bot, I disabled several test suites, so that the bot would at least start out green. We probably want these test suites running though, so we should at least investigate them to see if we can't re-enable them.

It's possible to mark them as experimental, so that they don't fail the build, and you can see what the actual errors are. That's already done for interactive_ui_tests on the bot. https://cs.chromium.org/chromium/src/testing/buildbot/test_suite_exceptions.pyl?q=exceptions.pyl&sq=package:chromium&g=0&l=1 has these modifications.

Full list:

* browser_tests
* components_browsertests
* content_shell_crash_test
* extensions_browsertests
* headless_browsertests
* interactive_ui_tests (experimental currently)
* service_manager_unittests
* telemetry_perf_unittests
* telemetry_unittests
* unit_tests
* viz_content_browsertests
* viz_browser_tests
* webkit_layout_tests
 

Comment 1 by grt@chromium.org, Jun 7 2018

Tests that timeout with errors like:

[7100:7924:0606/235612.761:ERROR:service_manager_context.cc(248)] Attempting to run unsupported native service: C:\b\s\w\ir\out\Debug_x64\chrome_renderer.service.exe

are likely caused by issue 651906. I'm slowly trying to get to the bottom of it. Also see issue 840369. I expect that any test suite that spins up sandboxed renderers will experience this problem.
Cc: awhalley@chromium.org brucedaw...@chromium.org
Back Ref (in case this this ticket gets out of sync/inaccurate): crbug/818832

Also, looks like one of the dbg bots was fabulously added as an optional try bot via Gerrit UI or cmdline: "win10_chromium_x64_dbg_ng".  (Ref: crbug/848513)  Turns out I'm not the only one landing CLs that only break on the waterfall dbg bot after landing!

CC brucedawson for chrome-windows (might want to delegate re-enabling these disabled suites on the dbg Win bot).

CC awhalley fyi.

Thanks!
Probably the issue described in comment 1.
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec52747a5abc25a862843edca761104b3c319764

commit ec52747a5abc25a862843edca761104b3c319764
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jan 14 16:16:49 2019

[ui_controls] Unflake Send*NotifyWhenDone() on Windows

ui_controls::Send*NotifyWhenDone() can be flaky when invoked after
ui_controls::Send*() as the former can decide to notify based on
observing a yet-to-be-processed event from the latter (or even a
yet-to-be-processed event emitted by unrelated code) and thus notify too
early, resuming and testing conditions that have yet to be met.

Solution: defer the notification if the system queue has pending events
of the same type awaiting dispatch.

Note: mouse move can be repeated indefinitely during a drag, as such we
consider a mouse move complete when it hits the target regardless of
remaining mouse move messages in the queue.

@ BUG OWNERS : This might unflake many currently disabled tests. I've
CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your
test after this CL if you think it might be related.

Bug:  892228 , 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467
Change-Id: I548856a3948ff71a145435799b4ba3e689561f14
Reviewed-on: https://chromium-review.googlesource.com/c/1392178
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622470}
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/ui/base/test/ui_controls_internal_win.cc

Sign in to add a comment