New issue
Advanced search Search tips

Issue 850342 link

Starred by 1 user
Status: Fixed
Owner:
cblume@chromium.org
Closed: Jun 2018
Cc:
ericrk@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 848388



Sign in to add a comment

Recent Skia Vulkan changes need to be reflected in Chrome's build

Project Member Reported by cblume@chromium.org, Jun 7 2018 
Recently, Skia changed its Vulkan code.
This ended up breaking Chrome when building with Vulkan support.
The Chrome build looks for a new header which isn't in the include dirs.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0ba24cec302a3dc2e6adedde5c75997d8f0e1f7

commit d0ba24cec302a3dc2e6adedde5c75997d8f0e1f7
Author: Chris Blume <cblume@chromium.org>
Date: Thu Jun 07 17:43:17 2018

Update Chrome Vulkan build to reflect Skia changes

Recently, Skia changed its Vulkan code.
This ended up breaking Chrome when building with Vulkan support.

This patch fixes the Chrome build with Vulkan.

BUG= 850342 

Change-Id: Ibd12791bca6b06d1124e6014766ed2958bea59c1
Reviewed-on: https://chromium-review.googlesource.com/1089817
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565328}
[modify] https://crrev.com/d0ba24cec302a3dc2e6adedde5c75997d8f0e1f7/skia/BUILD.gn

Comment 2 by cblume@chromium.org, Jun 7 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment