New issue
Advanced search Search tips

Issue 850337 link

Starred by 1 user
Status: Fixed
Owner:
xidac...@chromium.org
Closed: Jun 2018
Cc:
flackr@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create TouchActionFilterTest class and make each test to be TEST_F

Project Member Reported by xidac...@chromium.org, Jun 7 2018 
Once this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1068204 lands, we will have a ScrollingTouchActionForTesting() function in TouchActionFilter class. We should remove that class by creating a TouchActionFilterTest class and make it a friend of TouchActionFilter. This requires change all the TEST in the touch_action_filter_unittest.cc to be TEST_F.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be015f13686dad8f28115b272442d18835386852

commit be015f13686dad8f28115b272442d18835386852
Author: Xida Chen <xidachen@chromium.org>
Date: Sat Jun 09 12:01:17 2018

[Code health] Create TouchActionFilterTest class

Right now there is no such class, and that's why we added a
ScrollingTouchActionForTesting function in the TouchActionFilter class.

This CL creates a new TouchActionFilterTest class, and converts every
test in the file from TEST to TEST_F. It also cleans up the
TouchActionFilterPinchTest.

This CL should not introduce any behavior change, which can be tested
by bots.

Bug:  850337 
Change-Id: I355e43d3a6562efe779e8592aa95d1359f544443
Reviewed-on: https://chromium-review.googlesource.com/1091232
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565874}
[modify] https://crrev.com/be015f13686dad8f28115b272442d18835386852/content/browser/renderer_host/input/touch_action_filter.cc
[modify] https://crrev.com/be015f13686dad8f28115b272442d18835386852/content/browser/renderer_host/input/touch_action_filter.h
[modify] https://crrev.com/be015f13686dad8f28115b272442d18835386852/content/browser/renderer_host/input/touch_action_filter_unittest.cc

Comment 2 by xidac...@chromium.org, Jun 10 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment