New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850336 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Task



Sign in to add a comment

Update emoji_data.txt to v11

Project Member Reported by drott@chromium.org, Jun 7 2018

Issue description

Needed for updating emoji segmentation to that newer emojis are displayed correctly on Android P.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea082db3280dd6843ebfb08a625e3eb905c4f5ab

commit ea082db3280dd6843ebfb08a625e3eb905c4f5ab
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Jun 08 01:12:09 2018

Update emoji data to emoji_data.txt v11

For doing correct emoji segmentation for Emoji contained in Unicode 11,
update our emoji data to v11 [1] until we upgrade to ICU 62.

The SymbolsIterator test extracts all new sequences from
https://unicode.org/emoji/charts/emoji-released.html and makes a single
emoji sequence out of those. The test passes if the whole run has emoji
presentation.

[1] https://unicode.org/Public/emoji//11.0/emoji-data.txt

Test: SymbolsIteratorTest.Emoji11Additions, CharacterTest, EmojificationV11
Bug:  850336 
Change-Id: I72768a20e6dcc78bdaca67224c93e677c9ac5b70
Reviewed-on: https://chromium-review.googlesource.com/1091301
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565498}
[modify] https://crrev.com/ea082db3280dd6843ebfb08a625e3eb905c4f5ab/third_party/blink/renderer/platform/fonts/symbols_iterator_test.cc
[modify] https://crrev.com/ea082db3280dd6843ebfb08a625e3eb905c4f5ab/third_party/blink/renderer/platform/text/character_emoji.cc
[modify] https://crrev.com/ea082db3280dd6843ebfb08a625e3eb905c4f5ab/third_party/blink/renderer/platform/text/character_test.cc

Comment 3 by drott@chromium.org, Jun 8 2018

Labels: FoundIn-67 FoundIn-68 M-69 Target-69
Status: Fixed (was: Assigned)

Comment 4 by drott@chromium.org, Jun 8 2018

Cc: rsheeter@google.com

Comment 5 by drott@chromium.org, Jun 19 2018

Issue 838717 has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42eb6fbdb9e6783542d49235322aa92a4b4aebc9

commit 42eb6fbdb9e6783542d49235322aa92a4b4aebc9
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Jul 03 09:40:13 2018

Don't exclude unassigned characters from fallback

We tripped over this when adding Unicode 11 emoji. There is no need to
introduce an additional obstacle for characters that the OS or our Emoji
fallback code might already know about but our ICU might not have been
updated yet.

Bug:  850336 
Change-Id: I0748ac5b755a2d8c3b92be9c9e21cf96ed75be16
Reviewed-on: https://chromium-review.googlesource.com/1122407
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572159}
[modify] https://crrev.com/42eb6fbdb9e6783542d49235322aa92a4b4aebc9/third_party/blink/renderer/platform/fonts/font_cache.cc
[modify] https://crrev.com/42eb6fbdb9e6783542d49235322aa92a4b4aebc9/third_party/blink/renderer/platform/fonts/font_cache_test.cc
[modify] https://crrev.com/42eb6fbdb9e6783542d49235322aa92a4b4aebc9/third_party/blink/renderer/platform/text/character.cc
[modify] https://crrev.com/42eb6fbdb9e6783542d49235322aa92a4b4aebc9/third_party/blink/renderer/platform/text/character.h

Sign in to add a comment