New issue
Advanced search Search tips

Issue 850327 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

AR - hit-test vector doesn't scale properly when the orientation changes from landscape > portrait or vice versa

Project Member Reported by lincolnfrog@google.com, Jun 7 2018

Issue description

hit-test doesn't work accurately after an orientation change - the math to convert to 2d for the 2d API doesn't seem consistent
 
Owner: vollick@chromium.org
Status: Assigned (was: Unconfirmed)
Labels: M-69 Pri-1 Type-Bug
Owner: klausw@chromium.org
Status: Fixed (was: Assigned)
This was fixed by https://chromium-review.googlesource.com/1090215 :

commit 022934873f6e8e16f07e36fabe2bebc1635e91c3
Author: Klaus Weidner <klausw@chromium.org>
Date:   Thu Jun 7 02:36:38 2018 +0000

    Fix hit test position after rotations
    
    The pointer matrix for inverse perspective projection wasn't
    getting updated because UpdateProjectionMatrixFromRawValues
    wasn't setting inv_projection_dirty_, so it continued using
    the stale inverse after screen rotations.
    
    Change-Id: Iba2d404e2fdc0c7bdbd824c81b600c76626b35bc
    Reviewed-on: https://chromium-review.googlesource.com/1090215
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Commit-Queue: Klaus Weidner <klausw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#565153}

Components: Blink>WebXR

Sign in to add a comment