New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850325 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----
Proj-VR
Proj-XR



Sign in to add a comment

AR - hit-test with a vector that doesn't map to screen space causes chromium to crash

Project Member Reported by lincolnfrog@google.com, Jun 7 2018

Issue description

The hit-test promise should be rejected but chromium should not crash

 
Cc: asimjour@chromium.org
Owner: bajones@chromium.org
Status: Assigned (was: Unconfirmed)
Brandon, could you please take a look and re-assign it to the right person if needed?
Owner: klausw@chromium.org
I think Klaus has a fix for this.
Status: Fixed (was: Assigned)
This should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1090227 which is already merged:


commit 53d82aafe836bea3bf174fdd6a991eb26a47f687
Author: Klaus Weidner <klausw@chromium.org>
Date:   Thu Jun 7 04:05:58 2018 +0000

Fix crash on invalid hit test result

A failed AR hit test resulted in an attempt to run the single-use callback
twice due to a missing return. Update the logic to avoid this.

Change-Id: Iec07da17561da7f4896ce094bbcd5bf1cf037ed5
Reviewed-on: https://chromium-review.googlesource.com/1090227
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565174}
Components: Blink>WebXR

Sign in to add a comment