New issue
Advanced search Search tips

Issue 850303 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature


Previous locations:
gerrit:9148


Sign in to add a comment

Confusing top buttons

Reported by nisse@webrtc.org, Jun 4 2018

Issue description

I'm using the webrtc polygerrit instance 

I.e., https://webrtc-review.googlesource.com

Close to the top I have a row of action buttons that may include Code review + 1, CQ dry run, Abandon, Revert, Reland, ...

Selection of the set of buttons seems to depend on state of the cl. At the moment, on cl https://webrtc-review.googlesource.com/c/src/+/80442, I see a "Code Review + 1" button, which is not so useful since it's my own cl (self code review +1 is used for TBR, but that's not the common case).

And I see two "CQ Dry Run" buttons, which isn't so useful. Sometimes there's also a Submit button (don't see it at the moment, not not sure what the label is, possibly something like "Send to CQ" rather than "Submit"). 

Earlier today, on cl https://webrtc-review.googlesource.com/c/src/+/79561, the cl had state "ready to submit", but the Submit button was missing; instead I had to press "Reply" and select "CQ+2". My main source of confusion is that it's not at all clear to me when the Submit button is intended to be present.

In general, I think it's a bit confusing with buttons sometimes present, sometimes absent. I think I'd prefer a more stable UI with a fix set of buttons with some indication of the ones most likely to be useful (and preferably with a link or tooltip explaining why a button isn't applicable). 

Or at least have the button layout change only on the *major* state transitions, say, work in progress --> ready for review  -->  submitted --> reverted.  
 

Comment 1 by logan@google.com, Jun 6 2018

Project: chromium
Moved issue gerrit:9148 to now be issue chromium:850303.

Comment 2 by logan@google.com, Jun 6 2018

Components: Infra>Codereview>Gerrit
Labels: Pri-3 Type-Feature
Status: Available (was: New)

Sign in to add a comment