New issue
Advanced search Search tips

Issue 850301 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Previous locations:
gerrit:9088


Sign in to add a comment

CLs cannot be modified by people other than the change owner, even if they're not WIP anymore

Project Member Reported by ljusten@chromium.org, May 25 2018

Issue description

Affected Version: 2.15.1-4019-g265555227f

What steps will reproduce the problem?
1. Upload a new CL
2. Add a reviewer, so that it's not WIP anymore
3. Make some changes
4. Ask someone else to download your CL and make changes to it

What is the expected output?
The other person is allowed to make changes.

What do you see instead?
I get an error
 ! [remote rejected]           980fb3ebf5ba5807134ec9dad2f7b01ea19e7c1c -> refs/for/refs/heads/master%wip,m=Initial_upload,hashtag=chromad (only change owner can modify Work-in-Progress)
even though the CL is not WIP anymore.

Guess it's not a PolyGerrit issue. Can you please forward to the corresponding backend team? Thanks!


Please provide any additional information below.

I tried to upload PS4 to CL:1070372 (note: not WIP).

ad_policy_manager:ljusten@ljusten0:~/chromium/src$ git cl upload 
Running presubmit upload checks ...
Done processing /usr/local/google/home/ljusten/chromium/src/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
Done processing /usr/local/google/home/ljusten/chromium/src/chrome/browser/chromeos/policy/active_directory_policy_manager.h
Done processing /usr/local/google/home/ljusten/chromium/src/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc
Done processing /usr/local/google/home/ljusten/chromium/src/chrome/browser/chromeos/policy/component_active_directory_policy_browsertest.cc
Done processing /usr/local/google/home/ljusten/chromium/src/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

** Presubmit Messages **
Missing OWNER reviewers for these files:
    chrome/browser/chromeos/policy/active_directory_policy_manager.cc
    chrome/browser/chromeos/policy/active_directory_policy_manager.h
    chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc
    chrome/browser/chromeos/policy/component_active_directory_policy_browsertest.cc
    chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
    pmarko@chromium.org

Presubmit checks took 3.1s to calculate.

Presubmit checks passed.
 chrome/browser/chromeos/policy/active_directory_policy_manager.cc               |  57 +++++++++++++++++++++++++-----------------------------
 chrome/browser/chromeos/policy/active_directory_policy_manager.h                |  27 ++++++++++++--------------
 chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc      | 130 ++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------------
 chrome/browser/chromeos/policy/component_active_directory_policy_browsertest.cc |   4 ++--
 chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc          |  16 ++++++++--------
 5 files changed, 103 insertions(+), 131 deletions(-)
remote: Processing changes: refs: 1, done            
remote: (W) 980fb3e: commit subject >50 characters; use shorter first paragraph        
To https://chromium.googlesource.com/chromium/src.git
 ! [remote rejected]           980fb3ebf5ba5807134ec9dad2f7b01ea19e7c1c -> refs/for/refs/heads/master%wip,m=Initial_upload,hashtag=chromad (only change owner can modify Work-in-Progress)
error: failed to push some refs to 'https://chromium.googlesource.com/chromium/src.git'

Error after CL description prompt -- saving description to /usr/local/google/home/ljusten/.git_cl_description_backup

Failed to create a change. Please examine output above for the reason of the failure.
Hint: run command below to diagnose common Git/Gerrit credential problems:
  git cl creds-check

 

Comment 1 by logan@google.com, Jun 6 2018

Project: chromium
Moved issue gerrit:9088 to now be issue chromium:850301.

Comment 2 by logan@google.com, Jun 6 2018

Components: Infra>Codereview>Gerrit
Labels: Pri-3 Type-Bug
Status: Available (was: New)
I believe Logan moved this to Chrome assuming this has something to do with git cl upload trying to upload it as WIP when it's not. Needs some investigation to really know where things are going wrong though.

Sign in to add a comment