New issue
Advanced search Search tips

Issue 850297 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Clean up tests requiring workaround in ArcPlayStoreEnabledPreferenceHandler::OnPreferenceChanged()

Project Member Reported by jhorwich@chromium.org, Jun 6 2018

Issue description

In https://chromium-review.googlesource.com/c/chromium/src/+/1066737 I noticed that many tests inadvertently cause ArcPlayStoreEnabledPreferenceHandler::OnPreferenceChanged() to be called without signin_manager->IsAuthenticaed() to be true, unlike other calls to consent_audtior made by ARC.

For example, on linux-chromeos-rel, these browser_tests:
ArcAppLauncherBrowserTest.ShelfGroup
ArcSessionManagerTest.ManagedAndroidAccount

As well as some unit_tests as per https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/5795
ArcDefaulAppTest
ArcPlayStoreAppTest
ChromeAppIconTest.ChromeBadging
ChromeLauncherControllerArcDefaultAppsTest
ChromeLauncherControllerWithArcTest
NoteTakingHelperTest

This task is to fix these tests so we can restore the DCHECK / remove the runtime check of signin_manager->IsAuthenticated() in ArcPlayStoreEnabledPreferenceHandler::OnPreferenceChanged()
 
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment