New issue
Advanced search Search tips

Issue 850275 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR

Blocking:
issue 773882



Sign in to add a comment

Examine device/vr use of weakptr and callbacks. There may be cases where we don't call callbacks deterministically

Project Member Reported by billorr@chromium.org, Jun 6 2018

Issue description

We have a pattern of:
task_runner()->PostTask(
      FROM_HERE, base::BindOnce(&SomeClass::SomeFunction, GetWeakPtr())), where we expect to call callbacks inside SomeFunction.

However, if the weak pointer is invalidated before the callback is run, we may leave some callbacks uncalled, and therefore outstanding mojo calls may not be resolved, and promises may not resolve in blink.

Make a pass over where we do this to ensure we don't have bugs.  Add tests, and see if there are safer patterns.
 
Status: Assigned (was: Untriaged)
Components: Internals>XR
Removing Internals>VR component and assigning to Internals>XR
Components: -Internals>VR
Labels: VR-Desktop
Blocking: 773882
Labels: -Pri-3 Pri-2

Sign in to add a comment