Issue metadata
Sign in to add a comment
|
Compile failure on official.desktop.continuous Mac64 trunk builder. |
||||||||||||||||||||
Issue descriptionLink to builder : https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/12629 Link to Error log : https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fmac64_trunk%2F12629%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Error : __CF_USER_TEXT_ENCODING: 0x1F4:0x0:0x0 ninja: Entering directory `/b/c/b/mac64_trunk/src/out/Release' ninja: error: '../../chrome/installer/mac/internal/Google_Chrome.provisionprofile', needed by 'Google Chrome Packaging/Google_Chrome.provisionprofile', missing and no known rule to make it step returned non-zero exit code: 1 Note : I am still waiting for the next build to make sure if this is flake.
,
Jun 6 2018
,
Jun 6 2018
,
Jun 6 2018
There were internal changes landed in parallel that should have brought the missing file into src-internal. Are you sure this wasn't a transient failure?
,
Jun 6 2018
Has that src-internal change actually landed in src/DEPS yet?
,
Jun 6 2018
crbug.com/848052 for context. The four changes were: In the public repo: https://chromium.googlesource.com/chromium/src.git/+/b69d8c48da838196d9655402dd739e62227762a7 In private repos: https://chrome-internal.googlesource.com/chrome/theme/google_chrome/+/31af348ef1be1d7f282dad55ce1868a4e346aea3 https://chrome-internal.googlesource.com/chrome/installer/mac/internal/+/216f0fb72b8d4ffcd370c982af885de83029362f https://chrome-internal.googlesource.com/chrome/src-internal.git/+/7f9c442bc359a870396516dde28426980b64f183
,
Jun 6 2018
Re #c5: No, I didn't realize we had to update src/DEPS too. That would explain it I guess.
,
Jun 6 2018
It's supposed to auto-roll. It can be slow, but it seems like it should have happened by now :/ Maybe something broken in the roller?
,
Jun 6 2018
Autoroll is in progress https://src-internal-chromium-roll.skia.org/
,
Jun 6 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1089692 This is the CL. Looks like it's almost through CQ.
,
Jun 6 2018
The DEPS roll has landed now. Can you confirm that this fixes the build failure?
,
Jun 6 2018
There are new builds going now, which appear to be past the failure (which was happening immediately at the compile step).
,
Jun 6 2018
Oh, and if it wasn't obvious, for future reference, always wait for the src-internal roll before trying to use code added to src-internal :)
,
Jun 7 2018
Thanks, noted. (This was a bit of a special case, since we had to add a parameter to a script in //src that was invoked from a different script in src-internal. Though we could have made the new parameter optional to work around that, I guess.)
,
Jun 7 2018
Just to update, latest Mac trunk builds are still failing on official.desktop.continuous builder with the same log as in C#0. Link to the builder: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/12672 Link to the log: =============== https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fmac64_trunk%2F12672%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Looks like the fix is available in https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/12673 which is still compiling, will update the bug once this comnpiles successfully.
,
Jun 7 2018
Latest Mac trunk builds are compiling successfully now. https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pbomm...@chromium.org
, Jun 6 2018Status: Assigned (was: Available)