New issue
Advanced search Search tips

Issue 850257 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 855660
issue 856858
issue 857138
issue 858879
issue 878920



Sign in to add a comment

Run WebGL 2.0 conformance suite on Android on chromium.gpu.fyi waterfall and optional GPU trybot

Project Member Reported by kbr@chromium.org, Jun 6 2018

Issue description

The WebGL 2.0 conformance suite should be run on Android bots on the chromium.gpu.fyi waterfall and the android_optional_gpu_tests_rel trybot. Not running WebGL 2.0 conformance on Android is a significant gap in our testing.

It's unclear whether the Nexus 5X pool can be used for this purpose. Certainly this tryjob:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_optional_gpu_tests_rel/5090

had a large number of failures:

WebglConformance_conformance2_glsl3_array_in_complex_expression
WebglConformance_conformance2_glsl3_compare_structs_containing_arrays
WebglConformance_conformance2_glsl3_short_circuiting_in_loop_condition
WebglConformance_conformance2_glsl3_vector_dynamic_indexing
WebglConformance_conformance2_glsl3_vector_dynamic_indexing_swizzled_lvalue
WebglConformance_conformance2_rendering_blitframebuffer_filter_outofbounds
WebglConformance_conformance2_rendering_uniform_block_buffer_size
WebglConformance_conformance2_state_gl_object_get_calls
WebglConformance_conformance2_textures_video_tex_2d_rg8ui_rg_integer_unsigned_byte
WebglConformance_conformance2_textures_video_tex_2d_rgb8ui_rgb_integer_unsigned_byte
WebglConformance_conformance2_textures_video_tex_2d_rgb9_e5_rgb_half_float
WebglConformance_conformance2_textures_video_tex_2d_rgba8ui_rgba_integer_unsigned_byte
WebglConformance_conformance2_textures_video_tex_2d_srgb8_rgb_unsigned_byte
WebglConformance_conformance2_textures_webgl_canvas_tex_2d_srgb8_alpha8_rgba_unsigned_byte
WebglConformance_conformance_glsl_bugs_sampler_struct_function_arg
WebglConformance_conformance_glsl_bugs_sequence_operator_evaluation_order
WebglConformance_conformance_textures_misc_copytexsubimage2d_large_partial_copy_corruption
WebglConformance_conformance_textures_video_tex_2d_alpha_alpha_unsigned_byte
WebglConformance_conformance_textures_video_tex_2d_luminance_alpha_luminance_alpha_unsigned_byte
WebglConformance_conformance_textures_video_tex_2d_luminance_luminance_unsigned_byte
WebglConformance_conformance_uniforms_uniform_samplers_test
WebglConformance_deqp_data_gles3_shaders_conversions
WebglConformance_deqp_functional_gles3_pixelbufferobject
WebglConformance_deqp_functional_gles3_shaderderivate_dfdy
WebglConformance_deqp_functional_gles3_shaderoperator_binary_operator_09
WebglConformance_deqp_functional_gles3_shaderoperator_common_functions
WebglConformance_deqp_functional_gles3_shaderoperator_unary_operator_01
WebglExtension_WEBGL_compressed_texture_pvrtc
WebglExtension_WEBGL_compressed_texture_s3tc
WebglExtension_WEBGL_compressed_texture_s3tc_srgb


Now, the Nexus 5X pool is running a quite old version of Android -- Marshmallow. It's possible that just by running on a more recent release on the same hardware that conformance may be improved. On the other hand, WebGL 2.0.0 conformance was reached on a Pixel phone, so if those can be deployed with some scale then the tests ought to be able to pass on it.

 
Note that on Pixel 2 with PPP1.180208.014 there were even more failures than on Nexus 5X - 41 compared to 30.

WebglConformance_conformance2_glsl3_compare_structs_containing_arrays
WebglConformance_conformance2_glsl3_vector_dynamic_indexing_swizzled_lvalue
WebglConformance_conformance2_rendering_uniform_block_buffer_size
WebglConformance_conformance2_textures_video_tex_2d_rg8ui_rg_integer_unsigned_byte
WebglConformance_conformance2_textures_video_tex_2d_rgb8ui_rgb_integer_unsigned_byte
WebglConformance_conformance2_textures_video_tex_2d_rgb9_e5_rgb_half_float
WebglConformance_conformance2_textures_video_tex_2d_rgba8ui_rgba_integer_unsigned_byte
WebglConformance_conformance2_textures_video_tex_2d_srgb8_rgb_unsigned_byte
WebglConformance_conformance_textures_video_tex_2d_alpha_alpha_unsigned_byte
WebglConformance_conformance_textures_video_tex_2d_luminance_alpha_luminance_alpha_unsigned_byte
WebglConformance_conformance_textures_video_tex_2d_luminance_luminance_unsigned_byte
WebglConformance_deqp_functional_gles3_occlusionquery_conservative
WebglConformance_deqp_functional_gles3_occlusionquery_strict
WebglConformance_deqp_functional_gles3_shaderderivate_dfdy
WebglConformance_deqp_functional_gles3_shaderoperator_common_functions
WebglConformance_deqp_functional_gles3_transformfeedback_array_interleaved_lines
WebglConformance_deqp_functional_gles3_transformfeedback_array_interleaved_points
WebglConformance_deqp_functional_gles3_transformfeedback_array_interleaved_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_array_separate_lines
WebglConformance_deqp_functional_gles3_transformfeedback_array_separate_points
WebglConformance_deqp_functional_gles3_transformfeedback_array_separate_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_lines
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_points
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_lines
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_points
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_centroid
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_flat
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_smooth
WebglConformance_deqp_functional_gles3_transformfeedback_point_size
WebglConformance_deqp_functional_gles3_transformfeedback_position
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_lines
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_points
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_lines
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_points
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_triangles
WebglExtension_WEBGL_compressed_texture_pvrtc
WebglExtension_WEBGL_compressed_texture_s3tc
WebglExtension_WEBGL_compressed_texture_s3tc_srgb

Logs attached.
webgl.log.tar.xz
79.6 KB Download

Comment 2 by kbr@chromium.org, Jun 28 2018

Cc: kainino@chromium.org jdarpinian@chromium.org
Thanks for running these Yuly. CC'ing Kai and James explicitly - it looks like the transform feedback tests are failing on the Pixel 1 as well.

From gles3-driver-issues.txt ( b/22760309 ):
dEQP-GLES3.functional.transform_feedback.random.separate.triangles.1
dEQP-GLES3.functional.transform_feedback.random.interleaved.lines.3
dEQP-GLES3.functional.transform_feedback.random.interleaved.triangles.7
dEQP-GLES3.functional.transform_feedback.random.interleaved.triangles.8
dEQP-GLES3.functional.transform_feedback.random.interleaved.triangles.10

Comment 4 by kbr@chromium.org, Jun 29 2018

Blockedon: 858879
FYI, I'm bisecting WebglConformance_deqp_functional_gles3_transformfeedback_array_interleaved_lines.
Blockedon: 857138 855660 856858
At this point we're still waiting for more Pixel 2 phones to be deployed into the Swarming pool (Issue 857138) but need to move forward, so going to land the test suppressions from https://chromium-review.googlesource.com/1115802/ so that the tests would be green on this bot if they were running there.

Blockedon: 878920
Owner: jdarpinian@chromium.org
Status: Assigned (was: Available)
James is going to take over https://chromium-review.googlesource.com/1115802 and get it landed. He's already fixed some of the failures (the luminance/alpha video upload tests) in  Issue 878920 . It looks like some new tests have landed recently which will need suppression. Thanks James for your help.

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6829aab5f8698d265317183be5e6e50e4551edf9

commit 6829aab5f8698d265317183be5e6e50e4551edf9
Author: James Darpinian <jdarpinian@chromium.org>
Date: Thu Nov 29 00:44:19 2018

Add suppressions for Pixel 2 and Nvidia Shield TV

We're not yet enabling the tests to run on the waterfall due to lack
of hardware, but the tests currently pass with these suppressions.

Bug: 709351,  809233 , 830046, 850257,  874620 
Bug: 905006, 906735, 906735, 906737, 906739
Bug: 906740, 906742,  906743 , 906745, 906752
Change-Id: I7362e52e9df8ae8f591d11a4a1e272fa2b81b0b6
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1340275
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611965}
[modify] https://crrev.com/6829aab5f8698d265317183be5e6e50e4551edf9/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Sign in to add a comment