New issue
Advanced search Search tips

Issue 850250 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Skip UserSessionManager::UpdateEasyUnlockKeys when using PIN to sign-in

Project Member Reported by jdufault@chromium.org, Jun 6 2018

Issue description

It is possible to easy-unlock keys to get removed at various times, we should make sure PIN sign-in updates them. See UserSessionManager::UpdateEasyUnlockKeys
 
Summary: Skip UserSessionManager::UpdateEasyUnlockKeys when using PIN to sign-in (was: Validate UserSessionManager::UpdateEasyUnlockKeys when using PIN to sign-in)
Thanks for the bug.

We want to skip UserSessionManager::UpdateEasyUnlockKeys when using PIN to sign-in. These keys are wrapping user password and we don't want to re-create them wrapping the PIN.
Labels: -M-69 M-71
Cc: jdufault@chromium.org
Owner: wzang@chromium.org
Should be able to just check |user_context.IsUsingPin()| in https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/session/user_session_manager.cc?l=1802&rcl=f8fbfbbbf0b7aa42606eb18dc3672a96d95f8990
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f26b3a8d7e32ee9b257dd5819344aa4e3ee3534c

commit f26b3a8d7e32ee9b257dd5819344aa4e3ee3534c
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Oct 03 18:35:47 2018

cros: Skip UserSessionManager::UpdateEasyUnlockKeys when using PIN

Bug:  850250 
Change-Id: I1a7af66367665bcb1577b5c6efc3f2e5d2748113
Reviewed-on: https://chromium-review.googlesource.com/1171801
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596295}
[modify] https://crrev.com/f26b3a8d7e32ee9b257dd5819344aa4e3ee3534c/chrome/browser/chromeos/login/session/user_session_manager.cc

Status: Fixed (was: Assigned)

Sign in to add a comment