New issue
Advanced search Search tips

Issue 850238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change has_touch_event_handler_ in TouchActionFilter to Optional

Project Member Reported by xidac...@chromium.org, Jun 6 2018

Issue description

Once this CL lands:
https://chromium-review.googlesource.com/c/chromium/src/+/1068204, the above member is default to false.

We can either change this to optional, or default that to true.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d326b48bd894605b4e41e22f6f085af7c12274b

commit 0d326b48bd894605b4e41e22f6f085af7c12274b
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Aug 22 20:39:26 2018

Reset touch action at TouchActionFilter's constructor

When we start processing a gesture event, the
OnHasTouchEventHandler(false) IPC message may not yet
be received which means the |scrolling_touch_action_|
has no value and that results a crash.

This CL fixes the problem by call ResetTouchAction()
in TouchActionFilter's constructor. At that moment, the
|has_touch_event_handler_| is default to false which
will set both |allowed_touch_action_| and
|scrolling_touch_action_| to Auto.

Bug:  850238 ,  851644 
Change-Id: I36f3edf2b9292347f184458aa059904af1a2f597
Reviewed-on: https://chromium-review.googlesource.com/1180592
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585234}
[modify] https://crrev.com/0d326b48bd894605b4e41e22f6f085af7c12274b/content/browser/renderer_host/input/touch_action_filter.cc
[modify] https://crrev.com/0d326b48bd894605b4e41e22f6f085af7c12274b/content/browser/renderer_host/input/touch_action_filter.h
[modify] https://crrev.com/0d326b48bd894605b4e41e22f6f085af7c12274b/content/browser/renderer_host/input/touch_action_filter_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment