New issue
Advanced search Search tips

Issue 850232 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Maybe simplify the logic to apply horizontal margins for touchable/non-touchable menus

Project Member Reported by ftirelo@chromium.org, Jun 6 2018

Issue description

From msw@ in crrev.com/c/1089431/4/ui/views/controls/menu/menu_item_view.cc:

It'd probably be nice if we had a helper function to get the padding that checks for touchable internally, and then reduce the differences in logic in layout code (ie. it's not clear why touchable clobbers the other terms here to use some other layout logic). Save any changes like that for possible followup.

Since I don't have much knowledge of that specific code, I'd rather defer to newcomer@ who implemented some of those changes.
 
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
Mass UI Triage.

Sign in to add a comment