With LUCI builds indexed, findit should rely on those when mapping commit positions -> builds, and fallback to using buildbot/existing APIs if nothing available
this should solve the root cause of most of Flake Analyzer's errors and is now available. bumping to pri 1
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/466343e474c833fd1045374c80b86d031f1fac17 commit 466343e474c833fd1045374c80b86d031f1fac17 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Fri Jul 27 23:15:27 2018 [Findit] Flake Analyzer - GetIsolateShaPipeline to use new build indexing One of several changes needed to phase out step_util.GetValidBoundingBuildsForStep, which is the weakest point in Flake Analyzer. This change is to switch to using IsolatedTarget's methods to relevant builds by commit position, which should be significantly more robust. Builds not indexed are assumed not supported, as they should all be indexed in recent history. Bug: 850224 Change-Id: I5bedd3f22137ce983bd025d26a752de1edab39b5 Reviewed-on: https://chromium-review.googlesource.com/1153605 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/466343e474c833fd1045374c80b86d031f1fac17/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py [modify] https://crrev.com/466343e474c833fd1045374c80b86d031f1fac17/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py [modify] https://crrev.com/466343e474c833fd1045374c80b86d031f1fac17/appengine/findit/services/constants.py [modify] https://crrev.com/466343e474c833fd1045374c80b86d031f1fac17/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py [modify] https://crrev.com/466343e474c833fd1045374c80b86d031f1fac17/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py [modify] https://crrev.com/466343e474c833fd1045374c80b86d031f1fac17/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py [modify] https://crrev.com/466343e474c833fd1045374c80b86d031f1fac17/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/e20fe700ab3c857ad3aedc266d049405597bb199 commit e20fe700ab3c857ad3aedc266d049405597bb199 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Tue Jul 31 17:40:05 2018 [Findit] Flake Analyzer - Use IsolatedTarget in NextCommitPositionPipeline step_util.GetValidBoundingBuildsForStep is the weakest point in Flake Analyzer. This change removes that call in favor of using IsolatedTarget's calls to find builds surrounding a given commit position within NextCommitPositionPipeline. Bug: 850224 Change-Id: I5fe5fa336bd6c672c1edd384ca17eaf096d7e535 Reviewed-on: https://chromium-review.googlesource.com/1155408 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/services/step_util.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/common/waterfall/buildbucket_client.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/services/test/step_util_test.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/model/flake/master_flake_analysis.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/pipelines/flake_failure/next_commit_position_pipeline.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/model/flake/test/master_flake_analysis_test.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/common/waterfall/test/buildbucket_client_test.py [modify] https://crrev.com/e20fe700ab3c857ad3aedc266d049405597bb199/appengine/findit/pipelines/flake_failure/test/next_commit_position_pipeline_test.py
Comment 1 by lijeffrey@chromium.org
, Jul 27