New issue
Advanced search Search tips

Issue 850220 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] rationalization for country/state with identical field signature

Project Member Reported by parastoog@chromium.org, Jun 6 2018

Issue description

Country and State have identical signatures, and we can't predict the right type for them on the server side.

coolstuffinc.com
 

Comment 1 by se...@chromium.org, Jun 7 2018

https://shop.bbc.com/checkout/onepage/ is also another example of this one
Status: Started (was: Assigned)
Note: Both of the above examples are also synthetic fields. Multiple fields for one rational field.

Comment 4 by rogerm@chromium.org, Jun 14 2018

Summary: [Autofill] rationalization for country/state with identical field signature (was: [Autofill] rationalization for country/state.)

Comment 5 Deleted

Comment 6 Deleted

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7df8da933e7d71de191ee15e24a5346a53fc37f1

commit 7df8da933e7d71de191ee15e24a5346a53fc37f1
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Fri Jun 22 22:45:20 2018

[Autofill] Country/State rationalization.

Sometimes, server misidentifies countries and states,
and we can handle it with rationalization.
This usually happens when the form/field signature of
the two are identical. See go/rationalize-repeated-fields.

Tests + Refactoring.

Fixes: www.coolstuffinc.com
Bug:  850220 
Change-Id: I85f601cd37f6c24b51423c8d3ccee0fc117f4f12
Reviewed-on: https://chromium-review.googlesource.com/1099559
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569814}
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/chrome/browser/about_flags.cc
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/components/autofill/core/common/form_field_data.h
[modify] https://crrev.com/7df8da933e7d71de191ee15e24a5346a53fc37f1/tools/metrics/histograms/enums.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b585fd98b3fcd3564c40b509cff3d33f75d81e33

commit b585fd98b3fcd3564c40b509cff3d33f75d81e33
Author: Nico Weber <thakis@chromium.org>
Date: Sat Jun 23 20:45:31 2018

Revert "[Autofill] Country/State rationalization."

This reverts commit 7df8da933e7d71de191ee15e24a5346a53fc37f1.

Reason for revert:
Doesn't build on iOS bots:
https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942978656263239232%2F%2B%2Fsteps%2Fcompile%2F0%2Fstdout
../../components/autofill/core/browser/form_structure.cc:1320:60: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare]
  for (auto current_index = field_index - 1; current_index >= 0;
                                             ~~~~~~~~~~~~~ ^  ~

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=855881 for
figuring out why the regular bots didn't catch this.

Original change's description:
> [Autofill] Country/State rationalization.
> 
> Sometimes, server misidentifies countries and states,
> and we can handle it with rationalization.
> This usually happens when the form/field signature of
> the two are identical. See go/rationalize-repeated-fields.
> 
> Tests + Refactoring.
> 
> Fixes: www.coolstuffinc.com
> Bug:  850220 
> Change-Id: I85f601cd37f6c24b51423c8d3ccee0fc117f4f12
> Reviewed-on: https://chromium-review.googlesource.com/1099559
> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569814}

TBR=sebsg@chromium.org,parastoog@google.com

Change-Id: If9433043e5fc735988bfa34c556267d36398b080
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  850220 
Reviewed-on: https://chromium-review.googlesource.com/1112979
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569881}
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/chrome/browser/about_flags.cc
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/components/autofill/core/common/form_field_data.h
[modify] https://crrev.com/b585fd98b3fcd3564c40b509cff3d33f75d81e33/tools/metrics/histograms/enums.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/071d725ca22fa237aa68ba705a67b2caf6af5e49

commit 071d725ca22fa237aa68ba705a67b2caf6af5e49
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Tue Jun 26 17:35:22 2018

[Autofill] Country/State rationalization.

Sometimes, server misidentifies countries and states,
and we can handle it with rationalization.
This usually happens when the form/field signature of
the two are identical. See go/rationalize-repeated-fields.

Tests + Refactoring.

Fixes: www.coolstuffinc.com + bbc shipping/billing.
Bug:  850220 

Change-Id: I95cf22154d39a417a618e5d9252a3a0ff70b747a
Reviewed-on: https://chromium-review.googlesource.com/1115078
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570446}
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/chrome/browser/about_flags.cc
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/components/autofill/core/common/form_field_data.h
[modify] https://crrev.com/071d725ca22fa237aa68ba705a67b2caf6af5e49/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment