VR Browsing - Omnibox and controls are in the wrong location |
|||
Issue descriptionChrome Version: 69.0.3451.0 OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Open https://www.google.com What is the expected result? The Omnibox should be correctly displayed. What happens instead? The Omnibox is way out of position, over the Content pane. Also the Omnibox controls are all i the center of the box overlaid on one another. NOTE: It repro's without the Tabs enabled. This doesn't occur on 68.
,
Jun 6 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6a779bddb099e1d2ae21572a6ca557adc964c36 commit d6a779bddb099e1d2ae21572a6ca557adc964c36 Author: Ian Vollick <vollick@chromium.org> Date: Wed Jun 06 22:38:05 2018 [vr] Pass ShouldUpdateWorldSpaceTransform to descendants With this change, we should revert to the behavior prior to crrev.com/c/1087170, however the reported dirtiness will still only be true if the transform is actually updated. Bug:850210 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I6a038953e0b658d9ea0b9a64a599faf5073cde9b Reviewed-on: https://chromium-review.googlesource.com/1089854 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#565067} [modify] https://crrev.com/d6a779bddb099e1d2ae21572a6ca557adc964c36/chrome/browser/vr/elements/ui_element.cc
,
Jun 7 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dougman@chromium.org
, Jun 6 2018