New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850177 link

Starred by 1 user
Status: Fixed
Owner:
█ brunokim@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
khmel@chromium.org
yusukes@chromium.org
menegola@chromium.org
hidehiko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task

Blocking:
issue 836246



Sign in to add a comment

Refactor SupervisionTransition to ArcAccountType (or similar)

Project Member Reported by brunokim@chromium.org, Jun 6 2018 
After a discussion with hidehiko@, we decided to simplify the communication between Chrome and ARC regarding the transition between child accounts to regular, and vice-versa. Instead of sending an explicit command from Chrome to ARC when a transition happens, we will simply send  Chrome's present state (i.e., is_child or not). Arc will then be responsible for recognizing a transition, keeping track of its own intermediate state, recover from possible crashes, and communicate to Chrome about success or failure.

Full discussion: https://chromium-review.googlesource.com/c/chromium/src/+/1070658/7/chrome/browser/chromeos/arc/arc_session_manager.cc#913

Comment 1 by brunokim@chromium.org, Jun 6 2018 

Bike-shedding: what's the appropriate model here?

* bool is_child -- transmits all that is necessary, should be added as a different field in https://cs.chromium.org/chromium/src/third_party/cros_system_api/dbus/login_manager/arc.proto
* ArcAccountType account_type -- can be a simple rename of SupervisionTransition.

Comment 2 by brunokim@chromium.org, Jun 6 2018

Blocking: 836246
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/7129b9c8c37a02ad9a514aff5a36581a369641e7

commit 7129b9c8c37a02ad9a514aff5a36581a369641e7
Author: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Date: Thu Jun 21 23:31:26 2018

Rename SupervisionTransition to is_child.

This field was never used. I will remove the field once the references
to it are updated (in chromeos/platform2 project).

BUG= chromium:850177 
TEST=emerge-${BOARD} system_api

Change-Id: Ie998394f430ff422e184e5f6fe6ed82653b2e34b
Reviewed-on: https://chromium-review.googlesource.com/1089274
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@google.com>

[modify] https://crrev.com/7129b9c8c37a02ad9a514aff5a36581a369641e7/dbus/login_manager/arc.proto
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9abeb221048c5c3054b8338c8ded9a8b6a2c165f

commit 9abeb221048c5c3054b8338c8ded9a8b6a2c165f
Author: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Date: Sat Jun 23 00:22:24 2018

Rename SUPERVISION_TRANSITION to IS_CHILD in arc_setup.

BUG= chromium:850177 
TEST=FEATURES=test emerge-${BOARD} chromeos-login system_api
CQ-DEPEND=CL:1089274

Change-Id: If70fa352447e3d3cc3f7758ca932aafb368d72ba
Reviewed-on: https://chromium-review.googlesource.com/1098633
Commit-Ready: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Tested-by: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/9abeb221048c5c3054b8338c8ded9a8b6a2c165f/login_manager/session_manager_impl.cc
[modify] https://crrev.com/9abeb221048c5c3054b8338c8ded9a8b6a2c165f/arc/setup/arc_setup.cc
[modify] https://crrev.com/9abeb221048c5c3054b8338c8ded9a8b6a2c165f/login_manager/session_manager_impl_unittest.cc
[modify] https://crrev.com/9abeb221048c5c3054b8338c8ded9a8b6a2c165f/arc/setup/etc/arc-boot-continue.conf

Comment 5 by brunokim@chromium.org, Jun 28 2018

Status: Fixed (was: Started)
►

Sign in to add a comment