New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850176 link

Starred by 1 user
Status: Fixed
Owner:
hansberry@chromium.org
Closed: Oct 11
Cc:
█ jlklein@chromium.org
nohle@chromium.org
khorimoto@chromium.org
█ jordynass@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 870130


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Add Enterprise policy to toggle the ability to use SmartLock for the login screen

Project Member Reported by jhawkins@chromium.org, Jun 6 2018 
Currently this part of the feature is a preference (default off) that enables the use of SmartLock to login into the Chromebook (not just unlock).  We need an Enterprise policy such that SmartLock for unlock may be turned on but not SmartLock for login.

Comment 1 by jhawkins@chromium.org, Jun 19 2018

Status: Started (was: Assigned)

Comment 2 by jhawkins@chromium.org, Oct 8

Status: Assigned (was: Started)

Comment 3 by hansberry@chromium.org, Oct 8

Cc: hansberry@chromium.org
Labels: -M-69 M-71
Owner: hansberry@chromium.org

Comment 4 by hansberry@chromium.org, Oct 8

Cc: jlklein@chromium.org jordynass@chromium.org khorimoto@chromium.org nohle@chromium.org jhawkins@chromium.org

Comment 5 by khorimoto@chromium.org, Oct 8

Blocking: 870130

Comment 6 by hansberry@chromium.org, Oct 9

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab84b79ccd4848cf1b311b71d6b7959148876cf5

commit ab84b79ccd4848cf1b311b71d6b7959148876cf5
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Wed Oct 10 18:12:33 2018

Smart Lock: Add a policy setting for signin feature.

Listening on the new pref in proximity_auth_profile_pref_manager.cc
has been purposefully left out in this CL.

Bug:  850176 
Change-Id: Ibb5e68995a01e471475df56785dd2f6c67279d08
Reviewed-on: https://chromium-review.googlesource.com/c/1271882
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598404}
[modify] https://crrev.com/ab84b79ccd4848cf1b311b71d6b7959148876cf5/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/ab84b79ccd4848cf1b311b71d6b7959148876cf5/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/ab84b79ccd4848cf1b311b71d6b7959148876cf5/chromeos/services/multidevice_setup/public/cpp/prefs.cc
[modify] https://crrev.com/ab84b79ccd4848cf1b311b71d6b7959148876cf5/chromeos/services/multidevice_setup/public/cpp/prefs.h
[modify] https://crrev.com/ab84b79ccd4848cf1b311b71d6b7959148876cf5/components/policy/resources/policy_templates.json
[modify] https://crrev.com/ab84b79ccd4848cf1b311b71d6b7959148876cf5/tools/metrics/histograms/enums.xml

Comment 8 by hansberry@chromium.org, Oct 10

Status: Fixed (was: Started)

Comment 9 by jhawkins@chromium.org, Oct 11

Status: Started (was: Fixed)
Opening to attach the CL to listen to this pref in Smart Lock.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db240835bc8ba4124509be70eaf7f47cfdfb0167

commit db240835bc8ba4124509be70eaf7f47cfdfb0167
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Oct 11 17:44:57 2018

Smart Lock: Respect the sign-in allowed pref.

R=khorimoto@chromium.org

Bug:  850176 
Test: none
Change-Id: I4ff1cf26c2c50c7da6a8df64598877fdfa55b76d
Reviewed-on: https://chromium-review.googlesource.com/c/1275142
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598829}
[modify] https://crrev.com/db240835bc8ba4124509be70eaf7f47cfdfb0167/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/db240835bc8ba4124509be70eaf7f47cfdfb0167/chromeos/components/proximity_auth/proximity_auth_local_state_pref_manager.cc
[modify] https://crrev.com/db240835bc8ba4124509be70eaf7f47cfdfb0167/chromeos/components/proximity_auth/proximity_auth_local_state_pref_manager.h
[modify] https://crrev.com/db240835bc8ba4124509be70eaf7f47cfdfb0167/chromeos/components/proximity_auth/proximity_auth_pref_manager.h
[modify] https://crrev.com/db240835bc8ba4124509be70eaf7f47cfdfb0167/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.cc
[modify] https://crrev.com/db240835bc8ba4124509be70eaf7f47cfdfb0167/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.h

Comment 11 by jlklein@chromium.org, Oct 11

Status: Fixed (was: Started)
►

Sign in to add a comment