Mojave: Provide permission reason strings for all resources that Chrome uses |
|||||||
Issue descriptionChrome Version: 69.0.3451.0 OS: macOS 10.14 We should provide the following Info.plist keys for the main app's Info.plist. They need to be localized, so we'll need to get the localized values into the InfoPlist.strings using the infoplist_strings_tool. NSLocationUsageDescription NSCameraUsageDescription NSMicrophoneUsageDescription And I think we also may need NSPhotoLibraryUsageDescription for the media_galleries API.
,
Jun 13 2018
,
Jun 13 2018
Handing this one off to rsesek@ :)
,
Jun 13 2018
Elly: Can you work to get the strings we want to use, and then I can wire it up into the build?
,
Jun 13 2018
Yep! What context exactly do they appear in? I'll work with the UX writers to get proper strings.
,
Jun 13 2018
These will be shown in a system-controlled prompt when Chrome first requests access to the protected resource. Chrome will then display its own prompt to allow the specific site to use the resource. I was thinking something along the lines of: "Chrome needs access to your microphone to allow websites to use it. Chrome will ask if you want to allow each website to access to your microphone before giving the website access." There's a demo of it in this video: https://developer.apple.com/videos/play/wwdc2018/702/
,
Jun 13 2018
Alright, thanks! Shimi, can you take a look at this? How do we go about getting some strings here?
,
Jul 11
Ping on this - M69 is coming up and we need to land the strings.
,
Jul 12
String from Shimi: "Once Chrome has access, websites will be able to ask you for access." Screen recording of behavior with it specified:
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98ebb971ff030225ffc2017ad2db3d784aafc367 commit 98ebb971ff030225ffc2017ad2db3d784aafc367 Author: Robert Sesek <rsesek@chromium.org> Date: Fri Jul 13 16:55:21 2018 [Mac] Add a permission reason string for protected resource acceses. In Mojave, apps should provide a reason string that will be shown in the OS-mediated permission prompt for protected resources (e.g., camera, microphone, location). This adds the reason string and places it in the InfoPlist.strings files. Bug: 850175 Change-Id: I1b5c250aa50a2b4086e95c34521a82fae2405ea1 Reviewed-on: https://chromium-review.googlesource.com/1135114 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#574951} [modify] https://crrev.com/98ebb971ff030225ffc2017ad2db3d784aafc367/chrome/app/chromium_strings.grd [modify] https://crrev.com/98ebb971ff030225ffc2017ad2db3d784aafc367/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/98ebb971ff030225ffc2017ad2db3d784aafc367/chrome/tools/build/mac/infoplist_strings_util.mm
,
Jul 17
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rsesek@chromium.org
, Jun 6 2018