Requesting merge for https://chromium-review.googlesource.com/c/chromium/src/+/1089210 This work was originally done in https://bugs.chromium.org/p/chromedriver/issues/detail?id=2446 Note that this change is in Chromedriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so this will have no impact on Chrome binary that is shipping. see go/chromedriver-versioning and go/chops-proj-rev-27 for background. The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84504f3864a522f04716ac6b3ab701af35393c6d commit 84504f3864a522f04716ac6b3ab701af35393c6d Author: Caleb Rouleau <crouleau@chromium.org> Date: Wed Jun 06 06:21:17 2018 [ChromeDriver] Delete old DevToolsPort file if it exists. Bug: chromedriver:2446 Change-Id: I63cfdc367af8cdbfc7f116fb51a3e3148ee0a950 Reviewed-on: https://chromium-review.googlesource.com/1087803 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564803} [modify] https://crrev.com/84504f3864a522f04716ac6b3ab701af35393c6d/chrome/test/chromedriver/chrome_launcher.cc [modify] https://crrev.com/84504f3864a522f04716ac6b3ab701af35393c6d/chrome/test/chromedriver/chrome_launcher.h [modify] https://crrev.com/84504f3864a522f04716ac6b3ab701af35393c6d/chrome/test/chromedriver/chrome_launcher_unittest.cc [modify] https://crrev.com/84504f3864a522f04716ac6b3ab701af35393c6d/chrome/test/chromedriver/test/run_py_tests.py
Approving merge for M68. Branch:3440
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f30a72dadafe4f2fa69b71c204b5988ed7df04c commit 9f30a72dadafe4f2fa69b71c204b5988ed7df04c Author: Caleb Rouleau <crouleau@chromium.org> Date: Wed Jun 06 21:30:28 2018 [ChromeDriver] Delete old DevToolsPort file if it exists. Bug: chromedriver:2446 Bug: 850147 Change-Id: I63cfdc367af8cdbfc7f116fb51a3e3148ee0a950 Reviewed-on: https://chromium-review.googlesource.com/1087803 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#564803}(cherry picked from commit 84504f3864a522f04716ac6b3ab701af35393c6d) Reviewed-on: https://chromium-review.googlesource.com/1089210 Cr-Commit-Position: refs/branch-heads/3440@{#223} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/9f30a72dadafe4f2fa69b71c204b5988ed7df04c/chrome/test/chromedriver/chrome_launcher.cc [modify] https://crrev.com/9f30a72dadafe4f2fa69b71c204b5988ed7df04c/chrome/test/chromedriver/chrome_launcher.h [modify] https://crrev.com/9f30a72dadafe4f2fa69b71c204b5988ed7df04c/chrome/test/chromedriver/chrome_launcher_unittest.cc [modify] https://crrev.com/9f30a72dadafe4f2fa69b71c204b5988ed7df04c/chrome/test/chromedriver/test/run_py_tests.py
Comment 1 by abdulsyed@google.com
, Jun 6 2018