New issue
Advanced search Search tips

Issue 850137 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mac OOP-D Coverarge on Waterfall

Project Member Reported by jonr...@chromium.org, Jun 6 2018

Issue description

Until we launch OOP-D on Android, we should have parallel OOP-D / non-OOP-D coverage on the waterfall (set up similarly to other platforms). This will help prevent regressions.

This should be based off of the current coverage we have on Mac FYI bots.

 

Comment 1 by thakis@chromium.org, Jun 13 2018

In https://chromium-review.googlesource.com/c/chromium/src/+/833148/2/testing/buildbot/test_suites.pyl#1697 you say that things should be stable enough on mac that mac could use viz_gtests everywhere instead of just viz_fyi_gtests on fyi/mac. Is there any blocker for that? Swarming capacity? Or should that be fine to do?
It should be fine to enable them. I have a patch up that I was testing vs trybots: https://chromium-review.googlesource.com/c/chromium/src/+/1095687

However the mac_chromium_rel_ng hasn't cycled green yet on it. I've ran into what were a series of general flaking tests.

The latest failure looks like a new viz specific one, but once I address that I can send out the CL for review

Comment 3 by thakis@chromium.org, Jun 13 2018

Awesome, thanks!
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67f0028bbdd0e2379d318378c7af53191b9efb94

commit 67f0028bbdd0e2379d318378c7af53191b9efb94
Author: jonross <jonross@chromium.org>
Date: Fri Jun 15 16:39:13 2018

Enable Viz tests on Mac on Waterfall

The Viz work on Mac has stabilized. The flakes we see in tests on our FYI bots
are general flakes. The original GL and Surface Invariants errors that prevented
us from running on the waterfall have all been fixed.

This adds the Viz testing group to the list of mac tests.

TEST=viz_browser_tests, viz_content_browsertests, viz_content_unittests

Bug:  850137 
Change-Id: Ieef76cd4457bd967909cb56622fbfd243cbc38ae
Reviewed-on: https://chromium-review.googlesource.com/1095687
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567685}
[modify] https://crrev.com/67f0028bbdd0e2379d318378c7af53191b9efb94/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/67f0028bbdd0e2379d318378c7af53191b9efb94/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/67f0028bbdd0e2379d318378c7af53191b9efb94/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/67f0028bbdd0e2379d318378c7af53191b9efb94/testing/buildbot/filters/viz.browser_tests.filter
[modify] https://crrev.com/67f0028bbdd0e2379d318378c7af53191b9efb94/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/67f0028bbdd0e2379d318378c7af53191b9efb94/testing/buildbot/test_suites.pyl

Status: Fixed (was: Assigned)

Sign in to add a comment