New issue
Advanced search Search tips

Issue 850134 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

TACM: Add icons to wallpaper menus

Project Member Reported by newcomer@chromium.org, Jun 6 2018

Issue description

All in the title.

Link to spec:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZXS6M2rSjiqy/files/MCG16K9U0aaVgzSawIg2aLFHwMSJbxAVNpw

Assets are in the email sgabriel@ sent newcomer@
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9a79669128060b6b4c184efeabf7a187fef6de3

commit b9a79669128060b6b4c184efeabf7a187fef6de3
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 02 23:55:09 2018

cros: Add icons to wallpaper context menus

Three changes:
 - Add the icons for desktop context menu options.
 - Make the "Autohide Shelf" option a regular menu option.
   - This is because touchable menu items do not use the "check" type
     and was OKed by UX.
 - Remove the "Autohide" and "Shelf position" items in tablet mode.
   - This is requested by UX.

Bug:  850134 
Change-Id: I4bc7912687fbd8f1c3543301be511ac02277a859
Reviewed-on: https://chromium-review.googlesource.com/1159735
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580379}
[modify] https://crrev.com/b9a79669128060b6b4c184efeabf7a187fef6de3/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/b9a79669128060b6b4c184efeabf7a187fef6de3/ash/resources/vector_icons/auto_hide.icon
[add] https://crrev.com/b9a79669128060b6b4c184efeabf7a187fef6de3/ash/resources/vector_icons/shelf_position.icon
[add] https://crrev.com/b9a79669128060b6b4c184efeabf7a187fef6de3/ash/resources/vector_icons/wallpaper.icon
[modify] https://crrev.com/b9a79669128060b6b4c184efeabf7a187fef6de3/ash/shelf/shelf_context_menu_model.cc

Status: Fixed (was: Assigned)
Labels: Launcher-Shelf-Team

Sign in to add a comment