New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850117 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.contextual_suggestions.ContextualSuggestionsTest#testPeekWithPageScrollPercentage" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 6 2018

Issue description

"org.chromium.chrome.browser.contextual_suggestions.ContextualSuggestionsTest#testPeekWithPageScrollPercentage" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyeAsSBUZsYWtlIm1vcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuY29udGV4dHVhbF9zdWdnZXN0aW9ucy5Db250ZXh0dWFsU3VnZ2VzdGlvbnNUZXN0I3Rlc3RQZWVrV2l0aFBhZ2VTY3JvbGxQZXJjZW50YWdlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by mcnee@chromium.org, Jun 6 2018

Cc: huayinz@chromium.org
Components: UI>Browser>ContentSuggestions>Explore
Labels: OS-Android
Status: Available (was: Untriaged)
Flaky on android-marshmallow-arm64-rel

java.lang.AssertionError: Bottom sheet should be shown on >=50% scroll percentage. expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.chromium.chrome.browser.contextual_suggestions.ContextualSuggestionsTest.testPeekWithPageScrollPercentage(ContextualSuggestionsTest.java:664)
        ......
Still flaking.
Labels: -Pri-1 Pri-2
Owner: bauerb@chromium.org
Assigning to bauerb@, who touched this test file most recently, right at the time the flakes went from once/week to once/day.

Failure is
java.lang.AssertionError: Bottom sheet should be shown on >=50% scroll percentage. expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.chromium.chrome.browser.contextual_suggestions.ContextualSuggestionsTest.testPeekWithPageScrollPercentage(ContextualSuggestionsTest.java:664)
	at java.lang.reflect.Method.invoke(Method.java)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.chromium.base.test.params.ParameterizedFrameworkMethod.invokeExplosively(ParameterizedFrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:115)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:122)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
Cc: -huayinz@chromium.org bauerb@chromium.org
Owner: huayinz@chromium.org
Status: Assigned (was: Available)
I think this should still be assigned to me... Let's mark this as a flaky test first and I'll try to fix it on Monday.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cecc42cb25599ccddfa16eb78a6625877e1504b8

commit cecc42cb25599ccddfa16eb78a6625877e1504b8
Author: Becky Zhou <huayinz@chromium.org>
Date: Sat Jun 09 00:56:39 2018

Mark ContextualSuggestionsTest#testPeekWithPageScrollPercentage as flaky

TBR=twellington@chromium.org

Bug:  850117 
Change-Id: I4da8c971d98094b556d614f2c457d21c1fa16889
Reviewed-on: https://chromium-review.googlesource.com/1094114
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565802}
[modify] https://crrev.com/cecc42cb25599ccddfa16eb78a6625877e1504b8/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java

Labels: -Sheriff-Chromium
Optimistically removing from sheriff queue
Labels: zine-triaged
Mergedinto: 847340
Status: Duplicate (was: Assigned)

Sign in to add a comment