use https://cr-buildbucket.appspot.com/rpcexplorer/services/buildbucket.v2.Builds/GetBuild to load build info, including steps, in milo build view. Stop loading steps from logdog. Ideally stop loading annotation proto from logdog too.
Would this break annotated scripts? We still have some on WASM console.
this bug is specific to LUCI, Buildbot is out of scope. I believe all LUCI builds today are on recipes.
We still run annotated scripts on LUCI. But I think since this is done at a higher level (ie annotation proto stays the same), annotated scripts should still work.
Yes, WASM is still not on recipes even though it's nearly migrated to LUCI.
the primary blocker of this bug is fixed: steps and output properties returned by buildbucket api v2 are updated as build runs
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064 commit 12eb5ec7d47af23de9cf4bbe5ab7866931c7b064 Author: Ryan Tseng <hinoka@google.com> Date: Fri Dec 14 22:24:53 2018 [milo] Rename Step component type to StepLegacy Bug: 850113 Change-Id: Ib94af6a33c69965eb47d194f9c7bd5eb0e44a8f7 Reviewed-on: https://chromium-review.googlesource.com/c/1378949 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/rawpresentation/logDogBuild.go [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-canceled.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-exception.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-gerrit.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-internal.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-link.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-nested.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-patch-failure.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-running-logdog.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-running.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-timeout.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-unicode.json [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/frontend/ui/build_legacy.go [modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/frontend/ui/componenttype_string.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/396ed7651f7770d2cb73668b39ecde2055ae7198 commit 396ed7651f7770d2cb73668b39ecde2055ae7198 Author: Ryan Tseng <hinoka@google.com> Date: Mon Dec 17 22:43:18 2018 [milo] Introduce build.html based off of build.proto This adds a build.html that takes in a "BuildPage" struct, which wraps a buildbucket build.proto struct. This implementation is incomplete, but is accessible behind a hidden ?v2=1 flag. This also breaks Timeline, which previously depended on MiloBuild, but now depends on build.proto. A sample live build was captured from today as testdata. Bug: 850113 Change-Id: I417a19a65d4a1f7c2a942d648a12b57f07c4bde4 Reviewed-on: https://chromium-review.googlesource.com/c/1375309 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/Makefile [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/buildsource/buildbucket/build.go [add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/buildsource/buildbucket/build_legacy.go [add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/buildsource/buildbucket/html_data.go [add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/buildsource/buildbucket/testdata/linux-rel.build.jsonpb [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/appengine/static/buildbot/css/default.css [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/appengine/static/common/js/build.js [add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/appengine/templates/pages/build.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/appengine/templates/pages/build_legacy.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html [add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbucket.build-Test_page-_linux-rel.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-Basic_successful_build.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-canceled.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-exception.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-expired.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-gerrit.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-internal.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-link.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-nested.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-patch-failure.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-pending-logdog.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-pending.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-running-logdog.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-running.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-timeout.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-unicode.html [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/middleware.go [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/routes_test.go [add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/ui/build.go [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/ui/build_legacy.go [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/view_build.go [modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/view_build_legacy.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2237a617181dbfcee8b37f94a5b7d834f0f69fb0 commit 2237a617181dbfcee8b37f94a5b7d834f0f69fb0 Author: Ryan Tseng <hinoka@google.com> Date: Fri Dec 28 21:06:54 2018 Add blackfriday to deps.yaml blackfriday is used to render Markdown to HTML Bug: 850113 Change-Id: I8f9730293e4e932d593f443b525768f44c955937 Reviewed-on: https://chromium-review.googlesource.com/c/1387214 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#19735} [modify] https://crrev.com/2237a617181dbfcee8b37f94a5b7d834f0f69fb0/go/deps.lock [modify] https://crrev.com/2237a617181dbfcee8b37f94a5b7d834f0f69fb0/go/deps.yaml
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/21cbe1f4cc524c5d54d563951bc4c0687d57a8e7 commit 21cbe1f4cc524c5d54d563951bc4c0687d57a8e7 Author: Ryan Tseng <hinoka@google.com> Date: Thu Jan 03 22:34:28 2019 Add sanitized_anchor_name to go deps This is a dependency of blackfriday Output from deps.py update: Updated repos: https://code.googlesource.com/gocloud.git/+log/a5c6324a6e84..a93970efcf20 https://chromium.googlesource.com/external/github.com/aws/aws-sdk-go.git/+log/8234000fff96..29ae2fc88231 https://chromium.googlesource.com/external/github.com/kisielk/errcheck.git/+log/9e642955b59d..e14f8d59a22d https://chromium.googlesource.com/external/github.com/matttproud/golang_protobuf_extensions.git/+log/c12348ce28de..c182affec369 https://chromium.googlesource.com/external/github.com/pkg/errors.git/+log/059132a15dd0..ba968bfe8b2f https://chromium.googlesource.com/external/github.com/prometheus/client_golang.git/+log/3ba18b203370..fb3d5cb2ad57 https://chromium.googlesource.com/external/github.com/prometheus/procfs.git/+log/1dc9a6cbc91a..14fa7590c24d https://chromium.googlesource.com/external/github.com/stretchr/testify.git/+log/c45a1382af90..ffdc059bfe9c https://skia.googlesource.com/buildbot.git/+log/3e15e766dae7..ae4a64ed878f https://chromium.googlesource.com/external/github.com/google/starlark-go.git/+log/2c1f36271ed6..746fad3713e3 https://go.googlesource.com/crypto.git/+log/505ab145d0a9..ff983b9c42bc https://go.googlesource.com/tools.git/+log/d00ac6d27372..8a6051197512 https://code.googlesource.com/google-api-go-client.git/+log/65a46cafb132..19e022d8cf43 https://chromium.googlesource.com/external/github.com/grpc/grpc-go.git/+log/36f3126920fe..c71aa62423b3 Bug: 850113 Change-Id: I2f03e100aeee2f2533967f27b6996e8dd9e91078 Reviewed-on: https://chromium-review.googlesource.com/c/1394211 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#19765} [modify] https://crrev.com/21cbe1f4cc524c5d54d563951bc4c0687d57a8e7/go/deps.lock [modify] https://crrev.com/21cbe1f4cc524c5d54d563951bc4c0687d57a8e7/go/deps.yaml
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/c8dd3f84f0cd3a25d21c50586a454031414e7f47 commit c8dd3f84f0cd3a25d21c50586a454031414e7f47 Author: Ryan Tseng <hinoka@google.com> Date: Thu Jan 03 23:41:01 2019 [milo] Build.proto page: Fix steps, banner, logs, and hack for summary markdown Uses blackfriday to render markdown Bug: 850113 Change-Id: I2d8e0bcfe5d647ea57f517d31d022b97932be7ac Reviewed-on: https://chromium-review.googlesource.com/c/1385672 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/c8dd3f84f0cd3a25d21c50586a454031414e7f47/milo/frontend/appengine/static/buildbot/css/default.css [modify] https://crrev.com/c8dd3f84f0cd3a25d21c50586a454031414e7f47/milo/frontend/appengine/templates/pages/build.html [modify] https://crrev.com/c8dd3f84f0cd3a25d21c50586a454031414e7f47/milo/frontend/expectations/buildbucket.build-Test_page-_linux-rel.html [modify] https://crrev.com/c8dd3f84f0cd3a25d21c50586a454031414e7f47/milo/frontend/middleware.go [modify] https://crrev.com/c8dd3f84f0cd3a25d21c50586a454031414e7f47/milo/frontend/ui/build.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0a2952c0527e3566f542f072f90b20f76ce8adfd commit 0a2952c0527e3566f542f072f90b20f76ce8adfd Author: Ryan Tseng <hinoka@google.com> Date: Fri Jan 04 19:17:48 2019 [buildbucket] Swap step_text and links in summary_markdown Bug: 850113 Change-Id: I61f533772e168d036d13d5c105d82f32eda87d84 Reviewed-on: https://chromium-review.googlesource.com/c/1395781 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#19779} [modify] https://crrev.com/0a2952c0527e3566f542f072f90b20f76ce8adfd/appengine/cr-buildbucket/annotations.py
Comment 1 by no...@chromium.org
, Jun 6 2018