New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 843714
issue 932787

Blocking:
issue 704387
issue 799558
issue 826006
issue 852990
issue 881467
issue 901228
issue 908521
issue 910095
issue 852261
issue 854800
issue 862991
issue 888732
issue 896405



Sign in to add a comment
link

Issue 850113: build view: use GetBuild API and build protos

Reported by no...@chromium.org, Jun 6 2018 Project Member

Issue description

use 
https://cr-buildbucket.appspot.com/rpcexplorer/services/buildbucket.v2.Builds/GetBuild
to load build info, including steps, in milo build view.
Stop loading steps from logdog. Ideally stop loading annotation proto from logdog too.
 

Comment 1 by no...@chromium.org, Jun 6 2018

Blocking: 850105

Comment 2 by no...@chromium.org, Jun 7 2018

Blocking: -850105

Comment 3 by no...@chromium.org, Jun 13 2018

Blocking: 852261

Comment 4 by no...@chromium.org, Jun 14 2018

Blocking: 852990

Comment 5 by no...@chromium.org, Jun 19 2018

Blocking: 826006

Comment 6 by no...@chromium.org, Jun 21 2018

Blocking: 854800

Comment 7 by no...@chromium.org, Jul 19 2018

Blocking: 862991

Comment 8 by serg...@chromium.org, Jul 26 2018

Would this break annotated scripts? We still have some on WASM console.

Comment 9 by no...@chromium.org, Jul 26 2018

this bug is specific to LUCI, Buildbot is out of scope. I believe all LUCI builds today are on recipes.

Comment 10 by hinoka@chromium.org, Jul 26 2018

We still run annotated scripts on LUCI.  But I think since this is done at a higher level (ie annotation proto stays the same), annotated scripts should still work.

Comment 11 by serg...@chromium.org, Jul 26 2018

Yes, WASM is still not on recipes even though it's nearly migrated to LUCI.

Comment 12 by no...@chromium.org, Sep 6

Blocking: 881467

Comment 13 by no...@chromium.org, Sep 26

Blocking: 888732

Comment 14 by no...@chromium.org, Sep 26

Blockedon: 843714

Comment 15 by no...@chromium.org, Oct 1

Blocking: 704387

Comment 16 by no...@chromium.org, Oct 18

Blocking: 896405

Comment 17 by no...@chromium.org, Nov 2

Blocking: 901228

Comment 18 by no...@chromium.org, Nov 15

the primary blocker of this bug is fixed: steps and output properties returned by buildbucket api v2 are updated as build runs

Comment 19 by no...@chromium.org, Nov 26

Blocking: 908521

Comment 20 by hinoka@chromium.org, Nov 29

Owner: hinoka@chromium.org
Status: Started (was: Available)

Comment 21 by hinoka@chromium.org, Nov 29

Blocking: 910095

Comment 22 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064

commit 12eb5ec7d47af23de9cf4bbe5ab7866931c7b064
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Dec 14 22:24:53 2018

[milo] Rename Step component type to StepLegacy

Bug: 850113
Change-Id: Ib94af6a33c69965eb47d194f9c7bd5eb0e44a8f7
Reviewed-on: https://chromium-review.googlesource.com/c/1378949
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/rawpresentation/logDogBuild.go
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-canceled.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-exception.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-gerrit.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-internal.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-link.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-nested.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-patch-failure.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-running-logdog.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-running.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-timeout.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/buildsource/swarming/expectations/build-unicode.json
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/frontend/ui/build_legacy.go
[modify] https://crrev.com/12eb5ec7d47af23de9cf4bbe5ab7866931c7b064/milo/frontend/ui/componenttype_string.go

Comment 23 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/396ed7651f7770d2cb73668b39ecde2055ae7198

commit 396ed7651f7770d2cb73668b39ecde2055ae7198
Author: Ryan Tseng <hinoka@google.com>
Date: Mon Dec 17 22:43:18 2018

[milo] Introduce build.html based off of build.proto

This adds a build.html that takes in a "BuildPage" struct,
which wraps a buildbucket build.proto struct.

This implementation is incomplete, but is accessible behind a hidden ?v2=1 flag.

This also breaks Timeline, which previously depended on MiloBuild,
but now depends on build.proto.

A sample live build was captured from today as testdata.

Bug: 850113
Change-Id: I417a19a65d4a1f7c2a942d648a12b57f07c4bde4
Reviewed-on: https://chromium-review.googlesource.com/c/1375309
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/Makefile
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/buildsource/buildbucket/build.go
[add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/buildsource/buildbucket/build_legacy.go
[add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/buildsource/buildbucket/html_data.go
[add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/buildsource/buildbucket/testdata/linux-rel.build.jsonpb
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/appengine/static/buildbot/css/default.css
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/appengine/static/common/js/build.js
[add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/appengine/templates/pages/build.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/appengine/templates/pages/build_legacy.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/buildbucket.build-Test_page-_linux-rel.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-Basic_successful_build.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-gerrit.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-pending-logdog.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-pending.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/expectations/swarming.build-build-unicode.html
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/middleware.go
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/routes_test.go
[add] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/ui/build.go
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/ui/build_legacy.go
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/view_build.go
[modify] https://crrev.com/396ed7651f7770d2cb73668b39ecde2055ae7198/milo/frontend/view_build_legacy.go

Comment 24 by hinoka@chromium.org, Dec 20

Summary: build view: use GetBuild API and build protos (was: build view: use GetBuild API)

Comment 25 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2237a617181dbfcee8b37f94a5b7d834f0f69fb0

commit 2237a617181dbfcee8b37f94a5b7d834f0f69fb0
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Dec 28 21:06:54 2018

Add blackfriday to deps.yaml

blackfriday is used to render Markdown to HTML

Bug: 850113
Change-Id: I8f9730293e4e932d593f443b525768f44c955937
Reviewed-on: https://chromium-review.googlesource.com/c/1387214
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19735}
[modify] https://crrev.com/2237a617181dbfcee8b37f94a5b7d834f0f69fb0/go/deps.lock
[modify] https://crrev.com/2237a617181dbfcee8b37f94a5b7d834f0f69fb0/go/deps.yaml

Comment 26 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/21cbe1f4cc524c5d54d563951bc4c0687d57a8e7

commit 21cbe1f4cc524c5d54d563951bc4c0687d57a8e7
Author: Ryan Tseng <hinoka@google.com>
Date: Thu Jan 03 22:34:28 2019

Add sanitized_anchor_name to go deps

This is a dependency of blackfriday

Output from deps.py update:

Updated repos:
https://code.googlesource.com/gocloud.git/+log/a5c6324a6e84..a93970efcf20
https://chromium.googlesource.com/external/github.com/aws/aws-sdk-go.git/+log/8234000fff96..29ae2fc88231
https://chromium.googlesource.com/external/github.com/kisielk/errcheck.git/+log/9e642955b59d..e14f8d59a22d
https://chromium.googlesource.com/external/github.com/matttproud/golang_protobuf_extensions.git/+log/c12348ce28de..c182affec369
https://chromium.googlesource.com/external/github.com/pkg/errors.git/+log/059132a15dd0..ba968bfe8b2f
https://chromium.googlesource.com/external/github.com/prometheus/client_golang.git/+log/3ba18b203370..fb3d5cb2ad57
https://chromium.googlesource.com/external/github.com/prometheus/procfs.git/+log/1dc9a6cbc91a..14fa7590c24d
https://chromium.googlesource.com/external/github.com/stretchr/testify.git/+log/c45a1382af90..ffdc059bfe9c
https://skia.googlesource.com/buildbot.git/+log/3e15e766dae7..ae4a64ed878f
https://chromium.googlesource.com/external/github.com/google/starlark-go.git/+log/2c1f36271ed6..746fad3713e3
https://go.googlesource.com/crypto.git/+log/505ab145d0a9..ff983b9c42bc
https://go.googlesource.com/tools.git/+log/d00ac6d27372..8a6051197512
https://code.googlesource.com/google-api-go-client.git/+log/65a46cafb132..19e022d8cf43
https://chromium.googlesource.com/external/github.com/grpc/grpc-go.git/+log/36f3126920fe..c71aa62423b3

Bug: 850113
Change-Id: I2f03e100aeee2f2533967f27b6996e8dd9e91078
Reviewed-on: https://chromium-review.googlesource.com/c/1394211
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19765}
[modify] https://crrev.com/21cbe1f4cc524c5d54d563951bc4c0687d57a8e7/go/deps.lock
[modify] https://crrev.com/21cbe1f4cc524c5d54d563951bc4c0687d57a8e7/go/deps.yaml

Comment 28 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0a2952c0527e3566f542f072f90b20f76ce8adfd

commit 0a2952c0527e3566f542f072f90b20f76ce8adfd
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Jan 04 19:17:48 2019

[buildbucket] Swap step_text and links in summary_markdown

Bug: 850113
Change-Id: I61f533772e168d036d13d5c105d82f32eda87d84
Reviewed-on: https://chromium-review.googlesource.com/c/1395781
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19779}
[modify] https://crrev.com/0a2952c0527e3566f542f072f90b20f76ce8adfd/appengine/cr-buildbucket/annotations.py

Comment 30 by bugdroid, Jan 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c1b551cf2da3c8fe87ecd4b48c781ffe5c86b57a

commit c1b551cf2da3c8fe87ecd4b48c781ffe5c86b57a
Author: Ryan Tseng <hinoka@google.com>
Date: Mon Jan 28 19:49:56 2019

[milo] Remove tabs for changes/properties

The non-responsive tabs were unpopular (Feedback states that tab count should be either static or fully responsive).
Removing tabs improves time to first paint.

Bug: 850113
Change-Id: Id994376d1af0b064bfd54e6b218a7dd9c18800d3
Reviewed-on: https://chromium-review.googlesource.com/c/1435664
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: David Burger <dburger@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/c1b551cf2da3c8fe87ecd4b48c781ffe5c86b57a/milo/frontend/appengine/static/common/js/build.js
[modify] https://crrev.com/c1b551cf2da3c8fe87ecd4b48c781ffe5c86b57a/milo/frontend/appengine/templates/pages/build.html
[modify] https://crrev.com/c1b551cf2da3c8fe87ecd4b48c781ffe5c86b57a/milo/frontend/expectations/buildbucket.build-Test_page-_linux-rel.html

Comment 31 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/4dbd9f5d50c2372ca2bc4ae7d25f986a492e8cfd

commit 4dbd9f5d50c2372ca2bc4ae7d25f986a492e8cfd
Author: Ryan Tseng <hinoka@google.com>
Date: Tue Jan 29 18:11:50 2019

[milo] Link to the builder page correctly for v2 build page

* Handle v2 bucket names correctly for builder pages
* Actually add a builder page link for the build page

Bug: 850113
Change-Id: Id65d4346b33ba19bfe64a38e6d3bb6af80515a8c
Reviewed-on: https://chromium-review.googlesource.com/c/1441674
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/4dbd9f5d50c2372ca2bc4ae7d25f986a492e8cfd/milo/frontend/appengine/templates/pages/build.html
[modify] https://crrev.com/4dbd9f5d50c2372ca2bc4ae7d25f986a492e8cfd/milo/frontend/expectations/buildbucket.build-Test_page-_linux-rel.html
[modify] https://crrev.com/4dbd9f5d50c2372ca2bc4ae7d25f986a492e8cfd/milo/frontend/routes.go

Comment 32 by bugdroid, Jan 30

Project Member

Comment 33 by hinoka@google.com, Feb 12

Blocking: 799558

Comment 34 by hinoka@chromium.org, Feb 12

Components: -Infra>Platform>Milo>LUCI Infra>Platform>Milo
Moving Milo components (Infra>Platform>Milo>LUCI -> Infra>Platform>Milo)

Comment 35 by bugdroid, Feb 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/cc1dde071c59662e2e69ee000554ea05bbfbaa39

commit cc1dde071c59662e2e69ee000554ea05bbfbaa39
Author: Ryan Tseng <hinoka@google.com>
Date: Thu Feb 14 23:17:36 2019

[kitchen] Swap location of links and text in step summary

So that the links sit closer to the log links.

Bug: 850113
Change-Id: Iccd27a85d686e38f992f15b1cee84df284c7599d
Reviewed-on: https://chromium-review.googlesource.com/c/1474693
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/cc1dde071c59662e2e69ee000554ea05bbfbaa39/buildbucket/annotations.go
[modify] https://crrev.com/cc1dde071c59662e2e69ee000554ea05bbfbaa39/buildbucket/testdata/annotations/annotations.pb.txt
[modify] https://crrev.com/cc1dde071c59662e2e69ee000554ea05bbfbaa39/buildbucket/testdata/annotations/expected_steps.pb.txt

Comment 36 by bugdroid, Feb 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fc4419181073aec3cb97317a4f3caff62f19480d

commit fc4419181073aec3cb97317a4f3caff62f19480d
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Feb 15 02:03:17 2019

Roll infra/go/src/go.chromium.org/luci/ 340fb1e12..cc1dde071 (2 commits)

https://chromium.googlesource.com/infra/luci/luci-go/+log/340fb1e12ac9..cc1dde071c59

$ git log 340fb1e12..cc1dde071 --date=short --no-merges --format='%ad %ae %s'
2019-02-14 hinoka [kitchen] Swap location of links and text in step summary
2019-02-14 hinoka [logdog] Fix metric collection

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

Bug: 850113
Change-Id: I3353ce7ee83a747cc4f8b8f5e90de199a631d710
Reviewed-on: https://chromium-review.googlesource.com/c/1474803
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20705}
[modify] https://crrev.com/fc4419181073aec3cb97317a4f3caff62f19480d/DEPS

Comment 37 by hinoka@chromium.org, Feb 15

Blockedon: 932332

Comment 38 by bugdroid, Feb 15

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/22f65eab85425bf9974e7a29855b40d820ca03ae

commit 22f65eab85425bf9974e7a29855b40d820ca03ae
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Feb 15 22:25:37 2019

Comment 39 by nodir@google.com, Feb 15

Blockedon: 932787

Comment 41 by hinoka@chromium.org, Feb 19 (3 days ago)

Blockedon: -932332

Comment 42 by bugdroid, Feb 19 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/1ce81063cf3d24ac184bcec8fcf0afec264f0a28

commit 1ce81063cf3d24ac184bcec8fcf0afec264f0a28
Author: Ryan Tseng <hinoka@google.com>
Date: Tue Feb 19 22:21:08 2019

Comment 43 by bugdroid, Feb 20 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/3dab7a70bce848a6486670afc32d65ade65b8058

commit 3dab7a70bce848a6486670afc32d65ade65b8058
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Feb 20 00:37:09 2019

Comment 44 by bugdroid, Yesterday (28 hours ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a0d93045ff6a6b2425aa9960672131b8f83938be

commit a0d93045ff6a6b2425aa9960672131b8f83938be
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Feb 22 03:07:19 2019

Roll infra/go/src/go.chromium.org/luci/ cc1dde071..7f1f770bc (32 commits)

https://chromium.googlesource.com/infra/luci/luci-go/+log/cc1dde071c59..7f1f770bc135

$ git log cc1dde071..7f1f770bc --date=short --no-merges --format='%ad %ae %s'
2019-02-22 vadimsh [lucicfg] Extend the semantics of `tracked_files`.
2019-02-22 vadimsh [lucicfg] Add "build bug template" support to Milo config generator.
2019-02-22 vadimsh [lucicfg] Add support for Milo consoles.
2019-02-22 vadimsh [lucicfg] Add io.read_proto(...) to load serialized protos from files.
2019-02-22 vadimsh [starlarkproto] Support freezing of messages.
2019-02-22 vadimsh [starlarkproto] Implement automatic dict -> Message conversion in attr setter.
2019-02-22 fmatenaar [luci-token-server] Update pb.go for MintProjectToken RPC.
2019-02-22 smut [GCE] Configure Swarming bot process to autostart using systemd
2019-02-22 smut [GCE] Support configurable timeout for connecting to Swarming
2019-02-21 hinoka [milo] Remove prefetching and prerendering of build logs
2019-02-21 hinoka [annotations] Backslash Escape step links in markdown
2019-02-21 vadimsh [starlarkproto] Rename proto.to_pbtext to proto.to_textpb.
2019-02-21 vadimsh [starlarkproto] Implement toStarlarkValue.
2019-02-21 vadimsh [starlarkproto] Reduce FromProto implementation to toStarlarkValue(...).
2019-02-21 hinoka [milo] Swallow malformed build errors in builder page
2019-02-21 vadimsh [starlarkproto] Add proto.from_textpb and proto.from_jsonpb functions.
2019-02-21 hinoka [milo] Fix gerrit URLs
2019-02-20 fmatenaar [luci-token-server] Implement MintProjectToken RPC.
2019-02-20 seanabraham crostesting: Use correct proto go_package.
2019-02-20 smut Report value of DSCacheDisabled to tsmon
2019-02-20 vadimsh [lucicfg] Add `io.read_file` for loading text from external files.
2019-02-20 nodir [luci_notify] Compress body
2019-02-20 vadimsh [starlarkproto] Rename *builtinWithAttrs to *messageCtor.
2019-02-20 nodir [notify] Handle timeouts
2019-02-20 hinoka [milo] Add durations for ongoing events
2019-02-20 smut [GCE] Do not update VM entities with config-related changes
2019-02-19 tandrii cq: allow multiple gerrit hosts in 1 config.
2019-02-19 hinoka [milo] Change build links to use v2 bucket names.
2019-02-16 vadimsh [lucicfg] Add support for Milo builder lists.
2019-02-15 hinoka [milo] Add tags to build page
2019-02-15 hinoka [milo] Add OAuth2 auth method to HTML endpoints
2019-02-15 cmumford Fixed typo: queues.yaml => queue.yaml.

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

Bug: 850113
Change-Id: I74517599b28ffd169474786696ca0c9546f18c96
Reviewed-on: https://chromium-review.googlesource.com/c/1481544
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20848}
[modify] https://crrev.com/a0d93045ff6a6b2425aa9960672131b8f83938be/DEPS

Comment 45 by bugdroid, Today (8 hours ago)

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/8b9d00ab4b5db6237327191cf61f2fdd41374b9f

commit 8b9d00ab4b5db6237327191cf61f2fdd41374b9f
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Feb 22 22:58:10 2019

Sign in to add a comment