New issue
Advanced search Search tips

Issue 850103 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

MacViews: dark mode obscures menu text

Project Member Reported by ellyjo...@chromium.org, Jun 6 2018

Issue description

Enabling dark mode causes MacViews to use white text for menus, with results as in the attached screenshot.
 
Screen Shot 2018-06-06 at 11.15.21 AM.png
71.9 KB View Download
Labels: -Proj-Mac1014 Proj-MacMojave

Comment 2 by gov...@chromium.org, Jun 22 2018

Labels: Proj-MacViews

Comment 3 by gov...@chromium.org, Jun 28 2018

Cc: robliao@chromium.org ellyjo...@chromium.org
Any update there as this is marked as P1 for M69?
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69e38de5256ad69ee397b44bb11f66177d58d3b8

commit 69e38de5256ad69ee397b44bb11f66177d58d3b8
Author: Leonard Grey <lgrey@chromium.org>
Date: Fri Jun 29 18:36:37 2018

Mac: Opt out of Mojave dark mode

This is temporary until we have bandwidth to do a correct dark mode
implementation. Opting out fixes glitches caused by the system thinking
that Chrome is in dark mode (for example, light text colors where we
are expecting the system to provide dark text colors).

Bug:  850103 
Change-Id: I38d46631f714907231da89bd47bdd800ceb1bb3e
Reviewed-on: https://chromium-review.googlesource.com/1120744
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571561}
[modify] https://crrev.com/69e38de5256ad69ee397b44bb11f66177d58d3b8/chrome/app/app-Info.plist

Comment 5 by lgrey@chromium.org, Jun 29 2018

Status: Fixed (was: Assigned)
Labels: -M-69 Group-Mohave_Only

Sign in to add a comment