New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850087 link

Starred by 1 user
Status: Started
Owner:
█ nasko@chromium.org
Out until 24 Jan
Cc:
creis@chromium.org
lukasza@chromium.org
alex...@chromium.org
█ nasko@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add internals WebUI which gives access to process model data

Project Member Reported by nasko@chromium.org, Jun 6 2018 
Chrome's process model is complicated and very hard to reason about without attaching a debugger to examine internal state. We should add WebUI page to expose process model internals to allow developers to more easily troubleshoot and understand internal state.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4

commit 3e19fbd5dd60f4ffae2883ceca56eec10506a1f4
Author: Nasko Oskov <nasko@chromium.org>
Date: Wed Jun 13 00:13:29 2018

Add chrome://process-internals WebUI

This CL adds barebones implementation of chrome://process-internals
WebUI, which only shows the current Site Isolation mode and list
of origins isolated by policy or command line.

Bug: 850087
Change-Id: I14b8e20bc763488e8b4ea433599125c96c5ba8d3
Reviewed-on: https://chromium-review.googlesource.com/1091167
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566638}
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/BUILD.gn
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/BUILD.gn
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/BUILD.gn
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/OWNERS
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals.mojom
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_handler_impl.cc
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_handler_impl.h
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_ui.cc
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_ui.h
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/resources/process/process_internals.html
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/resources/process/process_internals.js
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/webui/content_web_ui_controller_factory.cc
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/content_resources.grd
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/common/url_constants.cc
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/common/url_constants.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4

commit 3e19fbd5dd60f4ffae2883ceca56eec10506a1f4
Author: Nasko Oskov <nasko@chromium.org>
Date: Wed Jun 13 00:13:29 2018

Add chrome://process-internals WebUI

This CL adds barebones implementation of chrome://process-internals
WebUI, which only shows the current Site Isolation mode and list
of origins isolated by policy or command line.

Bug: 850087
Change-Id: I14b8e20bc763488e8b4ea433599125c96c5ba8d3
Reviewed-on: https://chromium-review.googlesource.com/1091167
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566638}
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/BUILD.gn
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/BUILD.gn
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/BUILD.gn
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/OWNERS
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals.mojom
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_handler_impl.cc
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_handler_impl.h
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_ui.cc
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_ui.h
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/resources/process/process_internals.html
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/resources/process/process_internals.js
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/webui/content_web_ui_controller_factory.cc
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/content_resources.grd
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/common/url_constants.cc
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/common/url_constants.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4

commit 3e19fbd5dd60f4ffae2883ceca56eec10506a1f4
Author: Nasko Oskov <nasko@chromium.org>
Date: Wed Jun 13 00:13:29 2018

Add chrome://process-internals WebUI

This CL adds barebones implementation of chrome://process-internals
WebUI, which only shows the current Site Isolation mode and list
of origins isolated by policy or command line.

Bug: 850087
Change-Id: I14b8e20bc763488e8b4ea433599125c96c5ba8d3
Reviewed-on: https://chromium-review.googlesource.com/1091167
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566638}
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/BUILD.gn
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/BUILD.gn
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/BUILD.gn
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/OWNERS
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals.mojom
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_handler_impl.cc
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_handler_impl.h
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_ui.cc
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/process_internals/process_internals_ui.h
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/resources/process/process_internals.html
[add] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/resources/process/process_internals.js
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/browser/webui/content_web_ui_controller_factory.cc
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/content_resources.grd
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/common/url_constants.cc
[modify] https://crrev.com/3e19fbd5dd60f4ffae2883ceca56eec10506a1f4/content/public/common/url_constants.h

Comment 4 by nasko@chromium.org, Jun 15 2018

Labels: -Pri-3 Merge-Request-68 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Owner: nasko@chromium.org
Status: Started (was: Untriaged)
Requesting merge for M68 of the first CL in this series that gives us basic display of isolation mode. I've merged locally and verified that it works in a local build. It does not affect product functionality and allows us to tell whether Site Isolation is enabled or not, which is currently not possible on Android.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 15 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: There is .grd file changes and we are only 38 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by abdulsyed@google.com, Jun 16 2018

Labels: -Merge-Review-68 Merge-Approved-68
Approving merge to M68. Branch:3440
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 18 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/618b3eec08129e2b57f93fc6a162d6ecf05b789b

commit 618b3eec08129e2b57f93fc6a162d6ecf05b789b
Author: Nasko Oskov <nasko@chromium.org>
Date: Mon Jun 18 13:58:02 2018

Add chrome://process-internals WebUI (Merge into M68)

This CL adds barebones implementation of chrome://process-internals
WebUI, which only shows the current Site Isolation mode and list
of origins isolated by policy or command line.

TBR=nasko@chromium.org,dcheng@chromium.org

Bug: 850087
Change-Id: I14b8e20bc763488e8b4ea433599125c96c5ba8d3
Reviewed-on: https://chromium-review.googlesource.com/1091167
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566638}
Reviewed-on: https://chromium-review.googlesource.com/1102186
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#392}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/BUILD.gn
[modify] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/BUILD.gn
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/process_internals/BUILD.gn
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/process_internals/OWNERS
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/process_internals/process_internals.mojom
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/process_internals/process_internals_handler_impl.cc
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/process_internals/process_internals_handler_impl.h
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/process_internals/process_internals_ui.cc
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/process_internals/process_internals_ui.h
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/resources/process/process_internals.html
[add] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/resources/process/process_internals.js
[modify] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/browser/webui/content_web_ui_controller_factory.cc
[modify] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/content_resources.grd
[modify] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/public/common/url_constants.cc
[modify] https://crrev.com/618b3eec08129e2b57f93fc6a162d6ecf05b789b/content/public/common/url_constants.h
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5619a871df37069dbc964c8bc1b3314d7f8af2

commit 9e5619a871df37069dbc964c8bc1b3314d7f8af2
Author: Nasko Oskov <nasko@chromium.org>
Date: Wed Oct 03 20:37:33 2018

Create basic structure with panes for process-internals.

This CL borrows code and layout from chrome://inspect to allow us to have
multiple ways to view internals of the process model. Subsequent CLs
will fill in the actual data on those extra panes.

Bug: 850087
Change-Id: Ia2891804dd61346e86c44c4aca32daf57302aed4
Reviewed-on: https://chromium-review.googlesource.com/c/1255599
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596347}
[modify] https://crrev.com/9e5619a871df37069dbc964c8bc1b3314d7f8af2/content/browser/process_internals/process_internals_ui.cc
[add] https://crrev.com/9e5619a871df37069dbc964c8bc1b3314d7f8af2/content/browser/resources/process/process_internals.css
[modify] https://crrev.com/9e5619a871df37069dbc964c8bc1b3314d7f8af2/content/browser/resources/process/process_internals.html
[modify] https://crrev.com/9e5619a871df37069dbc964c8bc1b3314d7f8af2/content/browser/resources/process/process_internals.js
[modify] https://crrev.com/9e5619a871df37069dbc964c8bc1b3314d7f8af2/content/content_resources.grd
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2498284f74c1a96d736a895fcc29b5343384927f

commit 2498284f74c1a96d736a895fcc29b5343384927f
Author: Nasko Oskov <nasko@chromium.org>
Date: Sat Oct 06 02:02:05 2018

Add information about all WebContents in a profile to process-internals.

This CL adds basic information for all WebContents in the current
browser profile. For each one, the frame tree is displayed in a
tree UI.

Bug: 850087
Change-Id: I91e88f88ad97931fb708f97e44e12d676648c507
Reviewed-on: https://chromium-review.googlesource.com/c/1265022
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597397}
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/process_internals/BUILD.gn
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/process_internals/process_internals.mojom
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/process_internals/process_internals_handler_impl.cc
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/process_internals/process_internals_handler_impl.h
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/process_internals/process_internals_ui.cc
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/process_internals/process_internals_ui.h
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/resources/process/process_internals.css
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/resources/process/process_internals.html
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/browser/resources/process/process_internals.js
[modify] https://crrev.com/2498284f74c1a96d736a895fcc29b5343384927f/content/content_resources.grd
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/add0a11ab0da7b194345561e8f531aa2feabed09

commit add0a11ab0da7b194345561e8f531aa2feabed09
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Mon Oct 22 18:19:07 2018

Fix origin lock state on chrome://process-internals.

chrome://process-internals calculates and displays each process's
locked state by checking lock_url().  That won't give the correct
result, since lock_url() is computed before we lock the process, and
having it doesn't imply that the process will actually be locked in
the future.  Fix this to check the process's lock in
ChildProcessSecurityPolicy, which should always given the correct
result.

Bug: 850087
Change-Id: Ibf5e37fc69919e6c1e6a7e67943942cf6c93242d
Reviewed-on: https://chromium-review.googlesource.com/c/1287953
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601655}
[modify] https://crrev.com/add0a11ab0da7b194345561e8f531aa2feabed09/content/browser/process_internals/process_internals_handler_impl.cc
►

Sign in to add a comment