New issue
Advanced search Search tips

Issue 850080 link

Starred by 1 user
Status: Fixed
Owner:
ftirelo@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Menu margins inconsistent across platforms

Project Member Reported by ftirelo@chromium.org, Jun 6 2018 
During UX review for the new autofill dropdown, we noticed that some menu margins (also used by autofill) are not consistent across platforms:
 - item_left_margin
 - label_to_arrow_padding
 - icon_to_label_padding
 - label_to_minor_text_padding

Discussed with bettes@, ellyjones@, and kylixrd@ and they seem to prefer a simpler logic than a small difference in margins.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c10b81789243f16cebc8bab58f52a80dc216530b

commit c10b81789243f16cebc8bab58f52a80dc216530b
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Wed Jun 06 18:59:27 2018

Make some menu margins consistent across platforms

Bug:  850080 
Change-Id: Iec8fdc70bb943fa153a4ffbacadda9ea3478370e
Reviewed-on: https://chromium-review.googlesource.com/1088755
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564988}
[modify] https://crrev.com/c10b81789243f16cebc8bab58f52a80dc216530b/ui/views/controls/menu/menu_config.cc
[modify] https://crrev.com/c10b81789243f16cebc8bab58f52a80dc216530b/ui/views/controls/menu/menu_config_chromeos.cc
[modify] https://crrev.com/c10b81789243f16cebc8bab58f52a80dc216530b/ui/views/controls/menu/menu_config_mac.mm

Comment 2 by ftirelo@chromium.org, Jun 6 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment