New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850078 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 852359



Sign in to add a comment

[Payments] Add a toggle for canMakePayment enablement

Project Member Reported by ma...@chromium.org, Jun 6 2018

Issue description

Tracking bug to add a toggle for PaymentRequest's canMakePayment. 

When the toggle is disabled, canMakePayment should return false for all parameters.

We need this on Desktop, Android and iOS
 
What about the strings?

I would suggest to change the top preference from 'Autofill' to 'Autofill and payments' as we did on Android. And below preference for the toggle.

Title:       Can make payment query
Description: Allow websites query whether there is an installed payment method to complete a payment request. Always return false when disabled.
Cc: rfeng@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4

commit cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed Jun 06 20:40:13 2018

[Payments] Add toggle for canMakePayment enablement on Desktop

Bug:  850078 
Test: browser_tests
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I026e1098fedd85f6cf413d74fe596934794ae001
Reviewed-on: https://chromium-review.googlesource.com/1088873
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565025}
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/components/payments/content/payment_request.cc
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/components/payments/core/payment_prefs.cc
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/components/payments/core/payment_prefs.h
[modify] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/components/payments_strings.grdp
[add] https://crrev.com/cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4/components/payments_strings_grdp/IDS_SETTINGS_CAN_MAKE_PAYMENT_TOGGLE_LABEL.png.sha1

Android screenshot,
Screenshot_2018-06-07-09-36-15.png
154 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9db7f1860b02311172838ba3e6ebb01c13c1052c

commit 9db7f1860b02311172838ba3e6ebb01c13c1052c
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Jun 07 16:53:28 2018

[PR][IOS] Add a toggle to allow canMakePayment to return truthful value

Also changes canMakePayment() to behave as in normal mode to avoid
incognito mode detection as per other platforms

Bug:  850078 ,846698
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icdc3f79dd0a3cbc1d34e7e5d5e5ca2077a096b6c
Reviewed-on: https://chromium-review.googlesource.com/1089032
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565295}
[modify] https://crrev.com/9db7f1860b02311172838ba3e6ebb01c13c1052c/ios/chrome/browser/ui/payments/BUILD.gn
[modify] https://crrev.com/9db7f1860b02311172838ba3e6ebb01c13c1052c/ios/chrome/browser/ui/payments/payment_request_can_make_payment_egtest.mm
[modify] https://crrev.com/9db7f1860b02311172838ba3e6ebb01c13c1052c/ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm
[modify] https://crrev.com/9db7f1860b02311172838ba3e6ebb01c13c1052c/ios/chrome/browser/ui/payments/payment_request_manager.mm
[modify] https://crrev.com/9db7f1860b02311172838ba3e6ebb01c13c1052c/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/9db7f1860b02311172838ba3e6ebb01c13c1052c/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/9db7f1860b02311172838ba3e6ebb01c13c1052c/ios/chrome/browser/ui/settings/privacy_collection_view_controller_unittest.mm

iOS screenshot
Simulator Screen Shot - iPhone 8 - 2018-06-07 at 14.21.19.png
105 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31b51b0dc71d3cae17391a1246998241bfcfdbd8

commit 31b51b0dc71d3cae17391a1246998241bfcfdbd8
Author: gogerald <gogerald@google.com>
Date: Thu Jun 07 20:21:51 2018

[Payments] Add checkbox preference for CanMakePayment enablement on Android

Bug:  850078 
Change-Id: I414ccfe5457ea91f482ed18494c70b2dbc1681b4
Reviewed-on: https://chromium-review.googlesource.com/1089831
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565388}
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/chrome/android/java/res/xml/privacy_preferences.xml
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/chrome/browser/android/preferences/prefs.h
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/chrome/browser/android/preferences/prefs_unittest.cc
[modify] https://crrev.com/31b51b0dc71d3cae17391a1246998241bfcfdbd8/components/payments_strings.grdp

Comment 8 by ma...@chromium.org, Jun 7 2018

Cc: gov...@chromium.org
Labels: Merge-Request-68
Status: Fixed (was: Assigned)
Hi TPMs, we would need to merge a few changes to M68 due to a late requirement.

This also contains two new strings for M68.
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 7 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: There is .grd file changes and we are only 46 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org
+abdulsyed@ (M68 Release TPM) for merge review
Verified the fix on Chrome iOS Canary 69.0.3453.0
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge for M68. Branch:3440
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 9 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962

commit cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Sat Jun 09 22:44:04 2018

[PR][IOS] Add a toggle to allow canMakePayment to return truthful value

Also changes canMakePayment() to behave as in normal mode to avoid
incognito mode detection as per other platforms

Bug:  850078 ,846698
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icdc3f79dd0a3cbc1d34e7e5d5e5ca2077a096b6c
Reviewed-on: https://chromium-review.googlesource.com/1089032
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565295}(cherry picked from commit 9db7f1860b02311172838ba3e6ebb01c13c1052c)
Reviewed-on: https://chromium-review.googlesource.com/1094534
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#267}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962/ios/chrome/browser/ui/payments/BUILD.gn
[modify] https://crrev.com/cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962/ios/chrome/browser/ui/payments/payment_request_can_make_payment_egtest.mm
[modify] https://crrev.com/cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962/ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm
[modify] https://crrev.com/cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962/ios/chrome/browser/ui/payments/payment_request_manager.mm
[modify] https://crrev.com/cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/cdf6b8ce02b604357e21cc5ec9c6c5c726e9e962/ios/chrome/browser/ui/settings/privacy_collection_view_controller_unittest.mm

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c6cd899348e1cdd807d980a020ea53247bb1ac1

commit 2c6cd899348e1cdd807d980a020ea53247bb1ac1
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Jun 11 20:30:06 2018

[Payments] Add toggle for canMakePayment enablement on Desktop

Bug:  850078 
Test: browser_tests
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I026e1098fedd85f6cf413d74fe596934794ae001
Reviewed-on: https://chromium-review.googlesource.com/1088873
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565025}(cherry picked from commit cacb85e3438fb5b73f68f4e5e24da8dd7e7e8fb4)
Reviewed-on: https://chromium-review.googlesource.com/1096033
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#286}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/components/payments/content/payment_request.cc
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/components/payments/core/payment_prefs.cc
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/components/payments/core/payment_prefs.h
[modify] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/components/payments_strings.grdp
[add] https://crrev.com/2c6cd899348e1cdd807d980a020ea53247bb1ac1/components/payments_strings_grdp/IDS_SETTINGS_CAN_MAKE_PAYMENT_TOGGLE_LABEL.png.sha1

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3

commit b4c8ba739f1118720e84ef4bff3ca02966b9bfb3
Author: gogerald <gogerald@google.com>
Date: Mon Jun 11 21:18:55 2018

[Payments] Add checkbox preference for CanMakePayment enablement on Android

TBR=gogerald@google.com

(cherry picked from commit 31b51b0dc71d3cae17391a1246998241bfcfdbd8)

Bug:  850078 
Change-Id: I414ccfe5457ea91f482ed18494c70b2dbc1681b4
Reviewed-on: https://chromium-review.googlesource.com/1089831
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565388}
Reviewed-on: https://chromium-review.googlesource.com/1096279
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#289}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/chrome/android/java/res/xml/privacy_preferences.xml
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/chrome/browser/android/preferences/prefs.h
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/chrome/browser/android/preferences/prefs_unittest.cc
[modify] https://crrev.com/b4c8ba739f1118720e84ef4bff3ca02966b9bfb3/components/payments_strings.grdp

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd2e2d67b17f953c8a34bcc622e3c62c28fea92b

commit fd2e2d67b17f953c8a34bcc622e3c62c28fea92b
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Jun 12 04:23:50 2018

[PR] Update the string for the toggle to disable canMakePayment

Bug:  850078 
Change-Id: I7d891f397a9a431d7a3a75903d99f110d054ae09
Reviewed-on: https://chromium-review.googlesource.com/1095662
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566308}
[modify] https://crrev.com/fd2e2d67b17f953c8a34bcc622e3c62c28fea92b/components/payments_strings.grdp

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3ca570805aa3d68009a2953752e2e1edc54a016

commit f3ca570805aa3d68009a2953752e2e1edc54a016
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Jun 12 14:04:10 2018

[PR] Update the string for the toggle to disable canMakePayment

Bug:  850078 
Change-Id: I7d891f397a9a431d7a3a75903d99f110d054ae09
Reviewed-on: https://chromium-review.googlesource.com/1095662
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566308}(cherry picked from commit fd2e2d67b17f953c8a34bcc622e3c62c28fea92b)
Reviewed-on: https://chromium-review.googlesource.com/1097218
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#300}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/f3ca570805aa3d68009a2953752e2e1edc54a016/components/payments_strings.grdp

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16e4a782b21604ff6ca9f2fb24c93cd481f8ff04

commit 16e4a782b21604ff6ca9f2fb24c93cd481f8ff04
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Jun 12 14:32:17 2018

[Payments] Update Can Make Payment Toggle screenshot

Bug:  850078 
Change-Id: Ife7bb7f4e611a32d66ffd1d3a940de53f5d3b7c8
Reviewed-on: https://chromium-review.googlesource.com/1097220
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566418}
[modify] https://crrev.com/16e4a782b21604ff6ca9f2fb24c93cd481f8ff04/components/payments_strings_grdp/IDS_SETTINGS_CAN_MAKE_PAYMENT_TOGGLE_LABEL.png.sha1

Blockedon: 852359
Status: Verified (was: Fixed)
https://drive.google.com/file/d/1mOyVUhwV-NTjDHXfpyPYnXJVIIpRKwpt/view?usp=sharing
Verified on iPad Pro 12'9 iOS 11.4, iPhone X iOS 11.3.1 
Text is not the same as in the image in comment 7
String looks good vbhatsoori@. Thank you.

Sign in to add a comment