New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850068 link

Starred by 1 user
Status: Fixed
Owner:
backer@chromium.org
Closed: Sep 11
Cc:
█ kbr@chromium.org
piman@chromium.org
zmo@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-08-06
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 847543


Sign in to add a comment

Remove dead code for OSX GpuInit

Project Member Reported by backer@chromium.org, Jun 6 2018 
http://crrev.com/c/1087582 will make GpuInit on OSX similar to other platforms (linux, windows, android). If this CL sticks, we can remove some unnecessary OSX specific code paths.

GpuDataManagerImplPrivate::NeedsCompleteGpuInfoCollection can be simplified

OSX specific GpuServiceImpl::UpdateGpuInfoPlatform() code

We will get some early signal from canary. I will watch OSX GPU crash rates. But we don't expect strong signal until this goes to beta. Looks like this will be M69 branch. go/chromiumdash puts M69 beta promotion Aug 2, 2018. So next action date is sometime in August.

Comment 1 by kbr@chromium.org, Jun 6 2018

Blockedon: 847543

Comment 2 by monor...@bugs.chromium.org, Aug 6 

The NextAction date has arrived: 2018-08-06

Comment 3 by zmo@chromium.org, Aug 6

Cc: -zmo@chromium.org kbr@chromium.org piman@chromium.org backer@chromium.org
Owner: zmo@chromium.org
Since backer@ is on leave, I'll take this bug.

Comment 4 by backer@chromium.org, Aug 27 

@zmo: I'm back. Feel free to transfer this back to me. I'm happy to clean up the mess.

Comment 5 by zmo@chromium.org, Aug 27

Cc: -backer@chromium.org zmo@chromium.org
Owner: backer@chromium.org
Thank you. Sorry I didn't get around to clean this up!
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d92a738cebcba82607eedade957eac2ea45076d

commit 6d92a738cebcba82607eedade957eac2ea45076d
Author: Jonathan Backer <backer@chromium.org>
Date: Tue Sep 11 13:53:01 2018

Remove OSX specific GPU info collection code

Bug:  850068 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I8fdb2a09bb813492687ceb7c801571f1d2bd5c77
Reviewed-on: https://chromium-review.googlesource.com/1208362
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590288}
[modify] https://crrev.com/6d92a738cebcba82607eedade957eac2ea45076d/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/6d92a738cebcba82607eedade957eac2ea45076d/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/6d92a738cebcba82607eedade957eac2ea45076d/content/browser/gpu/gpu_data_manager_impl_private.h

Comment 7 by backer@chromium.org, Sep 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment