content::PreresolveUrl() migration to mojo API for the HostResolver |
||||||||||
Issue descriptionPresolveUrl() accesses the HostResolver through net::URLRequestContext. With network service, the browser process doesn't have access to net::URLRequestContext. +ericorth@ is working on mojo APIs for the HostResolver. Once that's ready, PresolveUrl() can be migrated to using it.
,
Jul 12
,
Aug 13
I can take this if no one is working on it.
,
Aug 13
FYI, this issue is the "resource_hints_impl.cc" entry in my list of to-migrate host resolutions: https://docs.google.com/spreadsheets/d/1Gb6aYHeZ0H1R9-nnOyWGEDFZFaSc_jwllPEBsOQ0KTU It's currently blocked on support for non-default priority. I'm actively working on that support right now in https://chromium-review.googlesource.com/c/chromium/src/+/1171574 and another CL for the mojo side. Hopefully all landed within a couple days.
,
Aug 15
Issue 874655 has been merged into this issue.
,
Aug 16
This probably won't be needed. The only clients of the content::PreresolveUrl() are chrome_browser_net::Predictor and predictors::PreconnectManager. predictors::PreconnectManager is the replacement for the chrome_browser_net::Predictor and which is already enabled by default. I'm currently converting predictors::PreconnectManager to use mojo API for the HostResolver. And I think we could leave chrome_browser_net::Predictor unsupported.
,
Aug 16
So you're saying you're planning on converting predictors::PreconnectManager to directly make host resolution requests rather than going through content::PreresolveUrl()? If so, SGTM as long as content::PreresolveUrl() and chrome_browser_net::Predictor are commented as deprecated.
,
Aug 16
Removing myself as owner, since it looks like we might not need this.
,
Aug 16
,
Aug 16
,
Aug 17
Yes, I already have a patch that does this. I've created Issue 875238 to track chrome_browser_net::Predictor deprecation.
,
Aug 21
,
Sep 4
,
Sep 7
,
Sep 7
Looks like Issue 875238 is making progress but still not complete to remove the remaining preresolve usage. So I'm leaving this bug open, but we likely won't ever have to do anything here except confirm that all preresolves are deleted or migrated to network service.
,
Oct 15
content::PreresolveUrl() was removed, closing this bug. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dxie@chromium.org
, Jun 8 2018