New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850066 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 821021



Sign in to add a comment

content::PreresolveUrl() migration to mojo API for the HostResolver

Project Member Reported by alexilin@chromium.org, Jun 6 2018

Issue description

PresolveUrl() accesses the HostResolver through net::URLRequestContext.
With network service, the browser process doesn't have access to net::URLRequestContext.
+ericorth@ is working on mojo APIs for the HostResolver. Once that's ready, PresolveUrl() can be migrated to using it. 

 

Comment 1 by dxie@chromium.org, Jun 8 2018

Labels: OS-Chrome OS-Windows OS-Mac OS-Linux
Labels: -Pri-3 Pri-1
Owner: cduvall@chromium.org
Status: Started (was: Available)
I can take this if no one is working on it.
FYI, this issue is the "resource_hints_impl.cc" entry in my list of to-migrate host resolutions:
https://docs.google.com/spreadsheets/d/1Gb6aYHeZ0H1R9-nnOyWGEDFZFaSc_jwllPEBsOQ0KTU

It's currently blocked on support for non-default priority.  I'm actively working on that support right now in https://chromium-review.googlesource.com/c/chromium/src/+/1171574 and another CL for the mojo side.  Hopefully all landed within a couple days.
 Issue 874655  has been merged into this issue.
This probably won't be needed. The only clients of the content::PreresolveUrl() are chrome_browser_net::Predictor and predictors::PreconnectManager.

predictors::PreconnectManager is the replacement for the chrome_browser_net::Predictor and which is already enabled by default.

I'm currently converting predictors::PreconnectManager to use mojo API for the HostResolver. And I think we could leave chrome_browser_net::Predictor unsupported.
Cc: morlovich@chromium.org
So you're saying you're planning on converting predictors::PreconnectManager to directly make host resolution requests rather than going through content::PreresolveUrl()? If so, SGTM as long as content::PreresolveUrl() and chrome_browser_net::Predictor are commented as deprecated.
Owner: ----
Status: Available (was: Started)
Removing myself as owner, since it looks like we might not need this.
Blocking: -809583
removing this from blocking 809583 (see comment #6).
Labels: -Proj-Servicification-Canary Proj-Servicification
Yes, I already have a patch that does this. I've created  Issue 875238  to track chrome_browser_net::Predictor deprecation.
Labels: -Pri-1 Hotlist-KnownIssue Pri-2
Labels: -Hotlist-KnownIssue
Labels: Proj-Servicification-Stable Hotlist-KnownIssue
Looks like  Issue 875238  is making progress but still not complete to remove the remaining preresolve usage.  So I'm leaving this bug open, but we likely won't ever have to do anything here except confirm that all preresolves are deleted or migrated to network service.
Status: WontFix (was: Available)
content::PreresolveUrl() was removed, closing this bug.

Sign in to add a comment