New issue
Advanced search Search tips

Issue 850057 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 2
Type: Bug
Q2



Sign in to add a comment

App displayed 2 pop ups upon simultaneously tapping on 2 options (and app crashes on selecting an option on the pop ups)

Project Member Reported by vbarig...@chromium.org, Jun 6 2018

Issue description

App Version: 69.0.3450.0 canary
iOS Version:  11.3.1
Device: iPhones only
URL: 

Precondition:
Enable ‘UI Refresh Phase 1 (#ui-refresh-phase-1) flag from chrome://flags

Steps to reproduce:
  1.  Launch chrome canary.
  2.  Open NTP
  3.  Simultaneously tap and hold on tabswitcher and Menu buttons.
  4.  Select any option.

Observed results:
At Step 3:  Notice that 2 pop ups are displayed.
At Step 4:  Notice that the app crashes.

Crash Log : https://crash.corp.google.com/browse?stbtiq=9124deeeed17959f

Expected results:
At Step 3:  Two actions should not take place at a time.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA

Type-bug-regression? No

Link to video/image: https://drive.google.com/file/d/1EaHOW3VyPaLabVsziwXUYLhWmwc77kFu/view?usp=sharing

Stack Trace:
Thread 0 (id: 0x303) CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x4d32bed5 ] MAGIC SIGNATURE THREAD
Stack Quality84%Show frame trust levels
0x0000000100a3fee8	(Chrome -web_state_list.mm:263 )	WebStateList::DetachWebStateAt(int)
0x0000000100a3fee0	(Chrome -observer_list.h:178 )	WebStateList::DetachWebStateAt(int)
0x0000000100a40154	(Chrome -web_state_list.mm:293 )	WebStateList::CloseWebStateAt(int, int)
0x0000000100ea1420	(Chrome -browser_view_controller.mm:4850 )	-[BrowserViewController closeCurrentTab]
0x0000000100b5fcc8	(Chrome -popup_menu_table_view_controller.mm:277 )	-[PopupMenuTableViewController executeActionForItem:origin:]
0x0000000100b5f080	(Chrome -popup_menu_table_view_controller.mm:136 )	-[PopupMenuTableViewController tableView:didSelectRowAtIndexPath:]
0x000000018c0bff0c	(UIKit + 0x0034ff0c )	-[UITableView _selectRowAtIndexPath:animated:scrollPosition:notifyDelegate:]
0x000000018c113b90	(UIKit + 0x003a3b90 )	-[UITableView _userSelectRowAtPendingSelectionIndexPath:]
0x000000018c19e8b4	(UIKit + 0x0042e8b4 )	_runAfterCACommitDeferredBlocks
0x000000018c194988	(UIKit + 0x00424988 )	_cleanUpAfterCAFlushAndRunDeferredBlocks
0x000000018c07954c	(UIKit + 0x0030954c )	_afterCACommitHandler
0x000000018218e90c	(CoreFoundation + 0x000ed90c )	__CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__
0x000000018218c234	(CoreFoundation + 0x000eb234 )	__CFRunLoopDoObservers
0x000000018218c880	(CoreFoundation + 0x000eb880 )	__CFRunLoopRun
0x00000001820acda4	(CoreFoundation + 0x0000bda4 )	CFRunLoopRunSpecific
0x000000018408f01c	(GraphicsServices + 0x0000b01c )	GSEventRunModal
0x000000018c08d788	(UIKit + 0x0031d788 )	UIApplicationMain
0x0000000100731010	(Chrome -chrome_exe_main.mm:54 )	main
0x0000000181b3dfbc	(libdyld.dylib + 0x00000fbc )	start

 
Components: UI>Browser>Toolbar
Labels: ReleaseBlock-Stable M-69
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Gauthier, could you take a look?  These buttons are both in the toolbar; maybe we should disable touch handling for other buttons once the touch down event is received for the first one?
Labels: -Restrict-View-Google
Labels: Q2
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f05b09a52f16f5ecf5e23e9b71c505d4915e8d12

commit f05b09a52f16f5ecf5e23e9b71c505d4915e8d12
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Jun 19 09:55:42 2018

Do not present popup menu if one is already shown

This CL avoid presenting a popup menu is there is already one shown.
This can be done by pressing simultaneously on two buttons.

Bug:  850057 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3e501235c3527217e9f354277e09bc353430b95b
Reviewed-on: https://chromium-review.googlesource.com/1104694
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568385}
[modify] https://crrev.com/f05b09a52f16f5ecf5e23e9b71c505d4915e8d12/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm

NextAction: 2018-06-20
Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-06-20
Status: Verified (was: Fixed)
Only one popup menu is displayed.
Verified on iPhone, iPad with Regular and Incognito modes.
Verified on M69.0.3473.0 canary
iOS: 11.4, 12

Sign in to add a comment