New issue
Advanced search Search tips

Issue 850056 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-2


Sign in to add a comment

CHECK failure: 1 <= levels in texture_manager.cc

Project Member Reported by ClusterFuzz, Jun 6 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5551906962014208

Fuzzer: libFuzzer_gpu_raster_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  1 <= levels in texture_manager.cc
  gpu::gles2::Texture::UpdateNumMipLevels
  gpu::gles2::Texture::SetImmutable
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=564546:564563

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5551906962014208

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 6 2018

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 6 2018

Cc: piman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jun 6 2018

Labels: Test-Predator-Auto-Owner
Owner: backer@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/774e03c6946af8fa37f226e3446bd80a5d27fd37 (Remove levels from RasterInterface).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20797261dc0080b25b11b5985c567ad6127fa32a

commit 20797261dc0080b25b11b5985c567ad6127fa32a
Author: Jonathan Backer <backer@chromium.org>
Date: Wed Jun 06 17:42:47 2018

Check tex_image_failed instead of glGetError

TextureManager does some validation and will reject a bad glTexImage2D
before it gets issued to the driver. We should prefer to check
tex_image_failed (which is set by TextureManager) over glGetError.

This issue was found by clusterfuzz. I added a gpu_unittest that fails
without this change because it hits DCHECKS in texture_manager.cc when
we call SetImmutable in raster_decoder.cc.

I have confirmed locally that this CL resolves the clusterfuzz issue.

Bug:  850056 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibedec4ccc9ec4e3758eb38292642a8671ee8f975
Reviewed-on: https://chromium-review.googlesource.com/1089030
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564953}
[modify] https://crrev.com/20797261dc0080b25b11b5985c567ad6127fa32a/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/20797261dc0080b25b11b5985c567ad6127fa32a/gpu/command_buffer/service/raster_decoder_unittest.cc
[modify] https://crrev.com/20797261dc0080b25b11b5985c567ad6127fa32a/gpu/command_buffer/service/raster_decoder_unittest_base.cc

Project Member

Comment 6 by ClusterFuzz, Jun 7 2018

ClusterFuzz has detected this issue as fixed in range 564946:564969.

Detailed report: https://clusterfuzz.com/testcase?key=5551906962014208

Fuzzer: libFuzzer_gpu_raster_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  1 <= levels in texture_manager.cc
  gpu::gles2::Texture::UpdateNumMipLevels
  gpu::gles2::Texture::SetImmutable
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=564546:564563
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=564946:564969

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5551906962014208

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jun 7 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5551906962014208 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment