New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850029 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
mbonadei@chromium.org
█ phoglund@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Build issue in third_party/abseil-cpp

Reported by milko.le...@mips.com, Jun 6 2018 
UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce the problem:
1. gn gen out/mips32r2 --args="is_debug=false target_os=\"linux\" target_cpu=\"mipsel\" is_clang=true mips_arch_variant=\"r2\""
2. ninja -C out/mips32r2 all

What is the expected behavior?
All Chromium Linux targets should be built.

What went wrong?
Build fails with error message:

FAILED: obj/third_party/abseil-cpp/absl/debugging/examine_stack/examine_stack.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/abseil-cpp/absl/debugging/examine_stack/examine_stack.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"332838-1\" -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DCR_SYSROOT_HASH=baaf37cdcbcf251fb9a4ccaf8b479722ae61fe49 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -no-canonical-prefixes --target=mipsel-linux-gnu -march=mipsel -mcpu=mips32r2 -mhard-float -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -isystem ../../third_party/abseil-cpp -std=gnu++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_mips-sysroot -fvisibility-inlines-hidden -Wno-c++98-compat-pedantic -Wno-conversion -Wno-covered-switch-default -Wno-deprecated -Wno-disabled-macro-expansion -Wno-double-promotion -Wno-comma -Wno-extra-semi -Wno-packed -Wno-padded -Wno-float-conversion -Wno-float-equal -Wno-format-nonliteral -Wno-gcc-compat -Wno-global-constructors -Wno-exit-time-destructors -Wno-nested-anon-types -Wno-non-modular-include-in-module -Wno-old-style-cast -Wno-range-loop-analysis -Wno-reserved-id-macro -Wno-shorten-64-to-32 -Wno-switch-enum -Wno-thread-safety-negative -Wno-undef -Wno-unknown-warning-option -Wno-unreachable-code -Wno-unused-macros -Wno-weak-vtables -Wbitfield-enum-conversion -Wbool-conversion -Wconstant-conversion -Wenum-conversion -Wint-conversion -Wliteral-conversion -Wnon-literal-null-conversion -Wnull-conversion -Wobjc-literal-conversion -Wno-sign-conversion -Wstring-conversion -c ../../third_party/abseil-cpp/absl/debugging/internal/examine_stack.cc -o obj/third_party/abseil-cpp/absl/debugging/examine_stack/examine_stack.o
../../third_party/abseil-cpp/absl/debugging/internal/examine_stack.cc:57:2: error: "Undefined Architecture."
#error "Undefined Architecture."
 ^
1 error generated.

Did this work before? Yes 562529

Chrome version: 562530  Channel: dev
OS Version: 
Flash Version: Shockwave Flash 29.0 r0

This issue started after WebRtc change [1], in which dependency on abseil was introduced. 
Build failure can be seen at MIPS buildbot build [2].

[1] https://webrtc.googlesource.com/src.git/+/9a89a491f801afb2a4fb0d90be397a4b2e553a95
[2] http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for_MIPS/builds/1885/steps/Build%20Chromium/logs/stdio

Comment 1 by davidben@chromium.org, Jun 6 2018

Cc: mbonadei@chromium.org phoglund@chromium.org
Components: Build
+abseil OWNERS, but I'm not sure MIPS is a supported architecture. If you want a fix to it, probably your best bet is to submit a patch to Abseil upstream and then it'll get picked up in Chromium. https://github.com/abseil/abseil-cpp

Comment 2 by davidben@chromium.org, Jun 6 2018

Status: ExternalDependency (was: Unconfirmed)

Comment 3 by mbonadei@chromium.org, Jun 7 2018 

Hi, yes we do not support MIPS actively on WebRTC (we used to have a trybot for Android, but we removed it since the MIPS ABI has been deprecated from Android NDK r16: https://groups.google.com/forum/#!topic/discuss-webrtc/E7uhRhut3jY).

Patches are welcome though, and I can help you upstreaming them in Abseil.

I think it is easier for you to just hack on the //third_party/abseil-cpp code in your checkout and then create a pull request at https://github.com/abseil/abseil-cpp. But let me know if you need help in doing it.

Comment 5 by mbonadei@chromium.org, Jun 13 2018

Status: Fixed (was: ExternalDependency)
The fix from upstream rolled into //third_party/abseil-cpp with https://chromium-review.googlesource.com/1097845.

Your issue should be fixed now. Feel free to re-open if there are other problems.
►

Sign in to add a comment