Non-Regression: Title is missing for App info window in overview mode |
||
Issue descriptionChrome Version: 67.0.3396.78/10575.54.0 Beta Channel Candy, Daisy & Reks OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Open App Info Window of any app>> Click on overview mode and observe Actual: Title is missing for App Info Window in overview mode. For all other windows, title is seen Expected: Title should be seen for App Info window in Overview mode This is a Non-Regression issue seen from M65 @sammiequon: Please confirm the issue
,
Jun 6 2018
Isn't there any kind of title and description we can surface for App info Window? What do we give accessibility screen readers to read?
,
Jun 7 2018
re #2 - There's a couple information we can forward from the extension to the window title, which is what overview takes as the title. Overview accessibility does not really work, so it probably just reads nothing.
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f9f47e11ad05331b8ce2a2976fbbc3d716c8aa0 commit 7f9f47e11ad05331b8ce2a2976fbbc3d716c8aa0 Author: Sammie Quon <sammiequon@google.com> Date: Fri Aug 17 18:00:53 2018 overview: Add title for app info dialogs. Also fix a crash on shutdown if one of those dialogs is open in overview. Test: manual Bug: 850028 Change-Id: I31917875dc7a1c770c61f48b04766e49ef4b9786 Reviewed-on: https://chromium-review.googlesource.com/1178891 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#584124} [modify] https://crrev.com/7f9f47e11ad05331b8ce2a2976fbbc3d716c8aa0/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/7f9f47e11ad05331b8ce2a2976fbbc3d716c8aa0/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
,
Aug 22
I just use the extension title in #4 - with no icon. sgabriel - Feel free to reopen if thats not what we want. |
||
►
Sign in to add a comment |
||
Comment 1 by sammiequon@chromium.org
, Jun 6 2018Labels: -Pri-2 Pri-3