New issue
Advanced search Search tips

Issue 850027 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jun 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Search result is seen on reset setting overlay after reloading page.

Reported by db...@etouch.net, Jun 6 2018 
Chrome Version: 67.0.3396.79 (Official Build) Revision 161bdad7314804dc8c72f850396fcd696e8863e8-refs/branch-heads/3396@{#755}(32/64 bit)
OS: Mac(10.12.6,10.13.1,10.13.6), Windows(7,8,8.1,10) and Linux(14.04) OS
 
What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://settings page and type 're' in search text field.
(2) Navigate to 'chrome://settings/resetProfileSettings?origin=userclick'(search result is not seen)
(3) Now reload the page and observe.

Actual: Search result is  seen on reset setting overlay after reloading page.

Expected:  Search result should not seen on reset setting overlay even after reloading page.

This is a regression issue,broken in 'M67', will soon update the other info:
Actual_Search.mp4
612 KB View Download
Expected_Search.mp4
557 KB View Download

Comment 1 by db...@etouch.net, Jun 6 2018

Labels: RegressedIn-67 Target-69 hasbisect FoundIn-69 FoundIn-68 Target-68
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 548982 (known good), but no later than 548989 (first known bad).
CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/972d135e00d4462bcd1443ea2b17ab6ef20d746a..34478381b6adb0298c4103ea72e2c2b88aaa1502

Suspect: r548986 ?

@dpapad Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is also seen on M67 Beta build #67.0.3396.62,. M68 Dev build #68.0.3440.15 and M69 Canary build #69.0.3451.0.

Comment 2 by db...@etouch.net, Jun 6 2018 

Note: Manual bisect range for the above issue is below:

Good Build:67.0.3390.0(Revision: 548637)
Bad Build: 67.0.3393.0(Revision: 549377)

Comment 3 by dpa...@chromium.org, Jun 6 2018

Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c643b09f9fddfdc7e6c1b9eddad429495fa1f633

commit c643b09f9fddfdc7e6c1b9eddad429495fa1f633
Author: dpapad <dpapad@chromium.org>
Date: Mon Jun 11 18:54:58 2018

Settings WebUI: Update elements to ignore during searching.

Recent changes in cr-dialog/cr-action-menu to not extend dialog, but to wrap
one, require updating the list.

Bug:  850027 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I44c77452693bd84b9e2d2fb3d9161ae41cf754df
Reviewed-on: https://chromium-review.googlesource.com/1093381
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566082}
[modify] https://crrev.com/c643b09f9fddfdc7e6c1b9eddad429495fa1f633/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/c643b09f9fddfdc7e6c1b9eddad429495fa1f633/chrome/test/data/webui/settings/search_settings_test.js

Comment 6 by dpa...@chromium.org, Jun 13 2018

Status: Fixed (was: Started)
►

Sign in to add a comment