Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of glider@chromium.org browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests Builders failed on: - Linux ChromiumOS MSan Tests: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests
interactive_ui_tests are also affected: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7471 Findit (?) suspects CL https://chromium-review.googlesource.com/c/chromium/src/+/1032230 with 91% confidence, assigning to Darren
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c1e38af69bf0f4deb7380692486b90129525226 commit 2c1e38af69bf0f4deb7380692486b90129525226 Author: Alexander Potapenko <glider@chromium.org> Date: Wed Jun 06 10:09:22 2018 Revert "[VK] Change KeyboardController::GetInstance to never return null." This reverts commit eb29c35590f6f06bae21de2a2f9805a2c440f900. Reason for revert: broke CrOS MSan bots: crbug.com/850020 BUG= 850020 Original change's description: > [VK] Change KeyboardController::GetInstance to never return null. > > Currently, KeyboardController::GetInstance returns null if the keyboard > is disabled. This patch changes it so that |GetInstance| always returns > a valid KeyboardController. > > However, existing code determines whether the keyboard is enabled by > checking whether KeyboardController is null or not. With this patch, > KeyboardController will never be null. So we have to replace the null > checks with calls to KeyboardController::enabled(). In some cases, > calls to KeyboardController::enabled() can be omitted, but we leave > that to a future patch for easier review. > > Bug: 731537 > Change-Id: Ica487e69bae0a589d79c726f131611f0bf934672 > Reviewed-on: https://chromium-review.googlesource.com/1032230 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564779} TBR=jamescook@chromium.org,yusukes@chromium.org,sky@chromium.org,yhanada@chromium.org,shend@chromium.org Change-Id: I6bf00360e30529ae5f3a1ac4d8a70efbb169e958 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731537 Reviewed-on: https://chromium-review.googlesource.com/1088567 Reviewed-by: Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#564842} [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/accessibility/touch_exploration_manager.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/keyboard/keyboard_observer_register.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/keyboard/keyboard_ui.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/login/ui/login_keyboard_test_base.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/magnifier/magnification_controller_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/root_window_controller.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/root_window_controller_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/shell.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/shell.h [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/shell_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/system/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/system/virtual_keyboard/virtual_keyboard_tray.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/wm/always_on_top_controller_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/wm/lock_action_handler_layout_manager_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/wm/lock_layout_manager.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/wm/lock_layout_manager_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/wm/lock_window_state.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/chromeos/extensions/input_method_api.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/chromeos/input_method/input_method_engine.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/chromeos/input_method/input_method_manager_impl.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/chromeos/login/app_launch_controller.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/chromeos/login/ui/webui_login_view.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/extensions/api/omnibox/omnibox_api_testbase.h [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/ui/ash/keyboard_controller_browsertest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/components/arc/BUILD.gn [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/components/arc/ime/DEPS [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/components/arc/ime/arc_ime_service.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/components/arc/ime/arc_ime_service.h [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/components/arc/ime/arc_ime_service_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/app_list/BUILD.gn [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/app_list/views/app_list_folder_view.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/app_list/views/app_list_view_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/app_list/views/apps_grid_view_unittest.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/keyboard/keyboard_event_filter.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/keyboard/keyboard_test_util.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/keyboard/keyboard_util.cc [modify] https://crrev.com/2c1e38af69bf0f4deb7380692486b90129525226/ui/keyboard/keyboard_util_unittest.cc
Relanded the code (after changes) w/o problems. Closing this issue.
Comment 1 by glider@chromium.org
, Jun 6 2018Owner: shend@chromium.org
Status: Assigned (was: Available)
Summary: browser_tests and interactive_ui_tests failing on chromium.memory/Linux ChromiumOS MSan Tests (was: browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests)